From f5c70e2a7792b2a8cb7199a1885a90e647d125e8 Mon Sep 17 00:00:00 2001 From: "R. Boujbel" Date: Tue, 21 Nov 2023 18:21:08 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Etienne Millon --- master_changes.md | 2 +- src/core/opamConsole.ml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/master_changes.md b/master_changes.md index 366d5bd3f77..09fdc292ecb 100644 --- a/master_changes.md +++ b/master_changes.md @@ -161,4 +161,4 @@ users) * `OpamSystem.mk_temp_dir`: resolve real path with `OpamSystem.real_path` before returning it [#5654 @rjbou] * `OpamSystem.resolve_command`: in command resolution path, check that the file is not a directory and that it is a regular file [#5606 @rjbou - fix #5585 #5597 #5650 #5626] * `OpamStd.Config.env_level`: fix level parsing, it was inverted (eg, "no" gives level 1, and "yes" level 0) [#5686 @smorimoto] - * `OpamConsole`: add `disable_carriage_return` to disable automatic addition of carriage return (`set_bynari_mode_out`) on stdou & stderr on Windows if out is not tty [#5715 @rjbou] + * `OpamConsole`: add `disable_carriage_return` to disable automatic addition of carriage return (`set_binary_mode_out`) on stdout & stderr on Windows if out is not tty [#5715 @rjbou] diff --git a/src/core/opamConsole.ml b/src/core/opamConsole.ml index e7c45f3231c..6af1b9e1dfa 100644 --- a/src/core/opamConsole.ml +++ b/src/core/opamConsole.ml @@ -41,7 +41,7 @@ let disable_carriage_return = if Sys.win32 && not OpamStd.Sys.tty_out then fun () -> set_binary_mode_out stdout true; - set_binary_mode_out stdout true + set_binary_mode_out stderr true else fun () -> ()