Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dune from explicitely installed packages in setup instructions #2019

Closed
cuihtlauac opened this issue Feb 1, 2024 · 1 comment · Fixed by #2020
Closed

Remove dune from explicitely installed packages in setup instructions #2019

cuihtlauac opened this issue Feb 1, 2024 · 1 comment · Fixed by #2020

Comments

@cuihtlauac
Copy link
Collaborator

cuihtlauac commented Feb 1, 2024 •
edited
Loading

In https://ocaml.org/install there is:

$ opam install dune merlin ocaml-lsp-server odoc ocamlformat utop dune-release

In https://ocaml.org/docs/installing-ocaml there is:

$ opam install dune ocaml-lsp-server odoc ocamlformat utop

@The-Amoghavarsha pointed this should be the same (issue #1995).

Aside having the same, we can also remove dune in both. It is a dependency pulled by all the other packages but utop.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in OCaml.org Feb 1, 2024
@The-Amoghavarsha
Copy link
Contributor

Okay, I'm going to remove dune from both.

The-Amoghavarsha pushed a commit to The-Amoghavarsha/ocaml.org that referenced this issue Feb 2, 2024
Fixes ocaml#2019 which stemed out from ocaml#1995
e7a52ba
@The-Amoghavarsha The-Amoghavarsha mentioned this issue Feb 2, 2024
Merged
sabine pushed a commit to The-Amoghavarsha/ocaml.org that referenced this issue Feb 5, 2024
@sabine
Fixes ocaml#2019 which stemed out from ocaml#1995
58a561e
sabine pushed a commit that referenced this issue Feb 5, 2024
@The-Amoghavarsha
(doc) Removing dune from setup instructions (#2020)
f2c36d4 
* Fixes #2019 which stemed out from #1995

* remove merlin, dune-release from install page

---------

Co-authored-by: Amoghavarsha <[email protected]>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in OCaml.org Feb 5, 2024
@cuihtlauac cuihtlauac mentioned this issue Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
OCaml.org
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing dune from setup instructions The-Amoghavarsha/ocaml.org
2 participants
@cuihtlauac @The-Amoghavarsha