From c50d37bf0fe76a7392a4a5dec02aee79182dcc5f Mon Sep 17 00:00:00 2001 From: Stephen Sherratt Date: Thu, 12 Sep 2024 07:17:36 +1000 Subject: [PATCH] Change colors to be more readable in light themes (#10890) Some of the text colors used by dune tend not to be readable on default light-themes terminals. Of course it will always be possible to configure your terminal so that some colors are too light/dark to read, but some of the preset themes on macos are unable to display some colors commonly used by dune. Signed-off-by: Stephen Sherratt --- doc/changes/10890.md | 2 ++ otherlibs/stdune/src/user_message.ml | 6 +++--- 2 files changed, 5 insertions(+), 3 deletions(-) create mode 100644 doc/changes/10890.md diff --git a/doc/changes/10890.md b/doc/changes/10890.md new file mode 100644 index 00000000000..738a0beb9d7 --- /dev/null +++ b/doc/changes/10890.md @@ -0,0 +1,2 @@ +- Change some colors to improve readability in light-mode terminals + (#10890, @gridbugs) diff --git a/otherlibs/stdune/src/user_message.ml b/otherlibs/stdune/src/user_message.ml index 559228fc644..444d5cddf42 100644 --- a/otherlibs/stdune/src/user_message.ml +++ b/otherlibs/stdune/src/user_message.ml @@ -159,9 +159,9 @@ module Print_config = struct | Kwd -> [ `Bold; `Fg_blue ] | Id -> [ `Bold; `Fg_yellow ] | Prompt -> [ `Bold; `Fg_green ] - | Hint -> [ `Italic; `Fg_white ] - | Details -> [ `Dim; `Fg_white ] - | Ok -> [ `Dim; `Fg_green ] + | Hint -> [ `Italic ] + | Details -> [ `Dim ] + | Ok -> [ `Fg_green ] | Debug -> [ `Underline; `Fg_bright_cyan ] | Success -> [ `Bold; `Fg_green ] | Ansi_styles l -> l