From 766a565e810088e820f082676b98583c2d96667b Mon Sep 17 00:00:00 2001 From: Predrag Gruevski <2348618+obi1kenobi@users.noreply.github.com> Date: Mon, 24 Apr 2023 11:35:11 -0400 Subject: [PATCH] Use the cargo-semver-checks GitHub Action for semver-checking MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Will provide a substantial performance improvement: - cargo-semver-checks v0.20 is orders of magnitude faster at checking large crates — 2354x faster on `aws-sdk-ec2`; - the GitHub Action caches baseline rustdoc JSON files which is worth another ~2x speedup. As discussed here: https://github.com/tokio-rs/tokio/pull/5437#issuecomment-1520366922 --- .github/workflows/ci.yml | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9392d5ef11f..00a6b613d5f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -254,17 +254,11 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - - name: Install Rust ${{ env.rust_stable }} - uses: dtolnay/rust-toolchain@master + - name: Check semver + uses: obi1kenobi/cargo-semver-checks-action@v2 with: - toolchain: ${{ env.rust_stable }} - - name: Install cargo-semver-checks - uses: taiki-e/install-action@v2 - with: - tool: cargo-semver-checks - - name: Check semver compatibility - run: | - cargo semver-checks check-release --release-type minor + rust-toolchain: ${{ env.rust_stable }} + release-type: minor cross-check: name: cross-check