Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to skip crates whose Cargo.toml version is already published on the registry #356

Open
obi1kenobi opened this issue Feb 9, 2023 · 0 comments
Labels
A-cli Area: engine around the lints C-enhancement Category: raise the bar on expectations

Comments

@obi1kenobi
Copy link
Owner

obi1kenobi commented Feb 9, 2023

@obi1kenobi I think if you could add an option to semver-checks that allows skipping the check of crates whose Cargo.toml version is identical to the latest published version, then this problem would be trivially solvable. You can't publish the same version on crates.io twice, so this would make it safe to skip the check in that case, and the first time it would fail is in the PR that changes the version number. Which is what we need.

Originally posted by @Finomnis in tokio-rs/tokio#5437 (comment)

Eventually, we want to implement a proper PR-centric workflow. In the meantime, a feature like this sounds like it could make using the current tool in PRs much easier.

@obi1kenobi obi1kenobi added A-cli Area: engine around the lints C-enhancement Category: raise the bar on expectations labels Feb 9, 2023
Stonks3141 added a commit to Stonks3141/pet-monitor-app that referenced this issue Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: engine around the lints C-enhancement Category: raise the bar on expectations
Projects
None yet
Development

No branches or pull requests

1 participant