Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support generating witnesses for manifest lints #1008

Open
obi1kenobi opened this issue Nov 30, 2024 · 2 comments
Open

Support generating witnesses for manifest lints #1008

obi1kenobi opened this issue Nov 30, 2024 · 2 comments
Labels
C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.

Comments

@obi1kenobi
Copy link
Owner

Lints' witness field currently only supports creating witnesses for source code breakage, not manifest breakage. It can generate Rust source code witnesses, but proving that manifest breakage has occurred requires generating a Cargo.toml file (plus, presumably, an empty lib.rs).

We need a way to optionally specify a Cargo.toml template in addition to the source code template that is currently supported by the witness field in lint files.

cc @suaviloquence — this is low priority at the moment, just a heads-up so you can keep an eye on it and mull over how we'd design witness support for manifests.

@obi1kenobi obi1kenobi added C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue. labels Nov 30, 2024
@suaviloquence
Copy link
Contributor

Would the lib.rs always necessarily be empty?

@obi1kenobi
Copy link
Owner Author

I'm not sure. Off the top of my head, I can't think of an example where we'd need lib.rs contents to prove breakage, but then again I can only think of a handful of manifest lints at the moment anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: raise the bar on expectations E-help-wanted Call for participation: Help is requested to fix this issue. E-mentor Call for participation: Mentorship is available for this issue.
Projects
None yet
Development

No branches or pull requests

2 participants