Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base release files should be pre-reasoned #1815

Open
StroemPhi opened this issue Aug 20, 2024 · 6 comments
Open

Base release files should be pre-reasoned #1815

StroemPhi opened this issue Aug 20, 2024 · 6 comments
Assignees

Comments

@StroemPhi
Copy link
Contributor

As discussed in the OBI Slack channel, we noticed that the base release of OBI is not pre-reasoned, which leads to obi:device not being an asserted child of obi:processed material. However, @cmungall wrote that base files should always be pre-reasoned as well.

StroemPhi added a commit to nmrML/nmrCV that referenced this issue Aug 21, 2024
… parents

as the base file is not yet pre-reasoned, as it should be (see also: obi-ontology/obi#1815)
@turbomam
Copy link
Contributor

NB results of reasoning are dependent on the choice of the reasoner

@turbomam
Copy link
Contributor

Most OBO ontologies (but not OBI) only use a single namespace in their base file.

@turbomam
Copy link
Contributor

Is just reasoning over the exiting obi-base.owl adequate?

@turbomam
Copy link
Contributor

including a base file is new-ish for OBI

@ddooley
Copy link
Contributor

ddooley commented Sep 9, 2024

Is it hermit or ELK that is prefered by OBOFoundry? What does ODK use by default?
BTW, was there any interest in OBI using ODK build platform some time?

@StroemPhi
Copy link
Contributor Author

According to here (https://oboacademy.github.io/obook/reference/base-specification) and me checking the Makefile of one of my ODK repos it is ELK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants