Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for node v12 #183

Open
josmas opened this issue Mar 26, 2020 · 0 comments
Open

Support for node v12 #183

josmas opened this issue Mar 26, 2020 · 0 comments
Labels

Comments

@josmas
Copy link

josmas commented Mar 26, 2020

Description of the bug
The library does not install on node v12. Given that v10 is now on maintenance and v12 is the current active, support would be appreciated.

Steps to reproduce

  1. Follow instructions and run npm install --save web3c on a machine running node v12.

Expected behavior
The module should install, but instead fails to do so.
Errors include, among many others:

In file included from ../src/node-boilerplate/inc/scrypt_async.h:28:
../src/node-boilerplate/inc/scrypt_common.h:39:63: error: too few arguments to function call, single argument 'context' was not specified
      N(obj->Get(Nan::New("N").ToLocalChecked())->Uint32Value()),
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^

Environment

  • OS: Both Mac and Docker image for node12
  • Versions of relevant software and tools: Empty project just with this library.

Additional information
The package still works (despite the multitude of deprecation warnings) on node v10.

Thanks!

@josmas josmas added the t:bug label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant