Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardizing to US english #382

Closed
arturkamieniecki opened this issue Jul 5, 2023 · 6 comments
Closed

Standardizing to US english #382

arturkamieniecki opened this issue Jul 5, 2023 · 6 comments
Labels
feature/robotics This item is related to robotics. good-first-issue Issue ready for a new contributor according to the help wanted guidelines. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/minor Lowest priority. Work that may be scheduled sig/simulation Categorizes an issue or PR as relevant to SIG Simulation sig/ui-ux Categorizes an issue or PR as relevant to SIG UI-UX.

Comments

@arturkamieniecki
Copy link
Contributor

arturkamieniecki commented Jul 5, 2023 •
edited
Loading

Some words are not spelled according to the US English spelling, such as Visualise in the ROS2SensorComponent. Contributing guidelines specify that the US English spelling should be applied.
@arturkamieniecki arturkamieniecki added good-first-issue Issue ready for a new contributor according to the help wanted guidelines. feature/robotics This item is related to robotics. labels Jul 5, 2023
@arturkamieniecki arturkamieniecki changed the title Spelling mistakes Standardizing to US english Jul 5, 2023
@aquav3
Copy link

aquav3 commented Jul 7, 2023

Can I take this one?

@arturkamieniecki
Copy link
Contributor Author

Can I take this one?

Feel free to contribute.
Make sure to follow the O3DE contributing guidelines.

@arturkamieniecki arturkamieniecki added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 7, 2023
@adamdbrw adamdbrw added priority/minor Lowest priority. Work that may be scheduled and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 24, 2023
@adamdbrw
Copy link
Contributor

@aquav3 are you still willing to contribute this improvement?

@byrcolin byrcolin added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/ui-ux Categorizes an issue or PR as relevant to SIG UI-UX. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation labels Jul 25, 2023
@michalpelka
Copy link
Contributor

Discussed in sig-simulation issue triage. I keep needs-triage label to issue triage it by sig/ui-ux.

@jhanca-robotecai
Copy link
Contributor

The PR that triggered this issue is implemented in #433

@adamdbrw
Copy link
Contributor

The original issue is fixed, this is otherwise low priority. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/robotics This item is related to robotics. good-first-issue Issue ready for a new contributor according to the help wanted guidelines. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/minor Lowest priority. Work that may be scheduled sig/simulation Categorizes an issue or PR as relevant to SIG Simulation sig/ui-ux Categorizes an issue or PR as relevant to SIG UI-UX.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@michalpelka @adamdbrw @byrcolin @aquav3 @arturkamieniecki @jhanca-robotecai