From 81d6a2c60960348ef9f5fecbc7343cce94b5ad73 Mon Sep 17 00:00:00 2001 From: jzonthemtn Date: Tue, 10 Dec 2024 10:57:02 -0500 Subject: [PATCH] Changing to <= --- .../eval/judgments/clickmodel/coec/CoecClickModel.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/opensearch-search-quality-evaluation-plugin/src/main/java/org/opensearch/eval/judgments/clickmodel/coec/CoecClickModel.java b/opensearch-search-quality-evaluation-plugin/src/main/java/org/opensearch/eval/judgments/clickmodel/coec/CoecClickModel.java index af46886..0a1193d 100644 --- a/opensearch-search-quality-evaluation-plugin/src/main/java/org/opensearch/eval/judgments/clickmodel/coec/CoecClickModel.java +++ b/opensearch-search-quality-evaluation-plugin/src/main/java/org/opensearch/eval/judgments/clickmodel/coec/CoecClickModel.java @@ -343,20 +343,21 @@ public Map getRankAggregatedClickThrough() throws Exception { } - for(int rank = 0; rank < parameters.getMaxRank(); rank++) { + // TODO: Should this be LTE or just LT? Is rank zero-based? + for(int rank = 0; rank <= parameters.getMaxRank(); rank++) { if(impressionCounts.containsKey(rank)) { if(clickCounts.containsKey(rank)) { // Calculate the CTR by dividing the number of clicks by the number of impressions. - LOGGER.debug("Position = {}, Impression Counts = {}, Click Count = {}", rank, impressionCounts.get(rank), clickCounts.get(rank)); + LOGGER.info("Position = {}, Impression Counts = {}, Click Count = {}", rank, impressionCounts.get(rank), clickCounts.get(rank)); rankAggregatedClickThrough.put(rank, clickCounts.get(rank) / impressionCounts.get(rank)); } else { // This document has impressions but no clicks, so it's CTR is zero. - LOGGER.debug("Position = {}, Impression Counts = {}, No clicks so CTR is 0", rank, clickCounts.get(rank)); + LOGGER.info("Position = {}, Impression Counts = {}, No clicks so CTR is 0", rank, clickCounts.get(rank)); rankAggregatedClickThrough.put(rank, 0.0); } @@ -364,14 +365,13 @@ public Map getRankAggregatedClickThrough() throws Exception { } else { // No impressions so the clickthrough rate is 0. - LOGGER.debug("No impressions for rank {}, so using CTR of 0", rank); + LOGGER.info("No impressions for rank {}, so using CTR of 0", rank); rankAggregatedClickThrough.put(rank, (double) 0); } } - openSearchHelper.indexRankAggregatedClickthrough(rankAggregatedClickThrough); return rankAggregatedClickThrough;