From 57a530ca857d9d10322f3e506d1d967dbd01689d Mon Sep 17 00:00:00 2001
From: jzonthemtn <jeff.zemerick@mtnfog.com>
Date: Wed, 11 Dec 2024 19:31:27 -0500
Subject: [PATCH] Changing to less than rank.

Signed-off-by: jzonthemtn <jeff.zemerick@mtnfog.com>
---
 .../eval/judgments/clickmodel/coec/CoecClickModel.java         | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/opensearch-search-quality-evaluation-plugin/src/main/java/org/opensearch/eval/judgments/clickmodel/coec/CoecClickModel.java b/opensearch-search-quality-evaluation-plugin/src/main/java/org/opensearch/eval/judgments/clickmodel/coec/CoecClickModel.java
index b50ceb0..e660472 100644
--- a/opensearch-search-quality-evaluation-plugin/src/main/java/org/opensearch/eval/judgments/clickmodel/coec/CoecClickModel.java
+++ b/opensearch-search-quality-evaluation-plugin/src/main/java/org/opensearch/eval/judgments/clickmodel/coec/CoecClickModel.java
@@ -356,8 +356,7 @@ public Map<Integer, Double> getRankAggregatedClickThrough() throws Exception {
 
         }
 
-        // TODO: Should this be LTE or just LT? Is rank zero-based?
-        for(int rank = 0; rank <= parameters.getMaxRank(); rank++) {
+        for(int rank = 0; rank < parameters.getMaxRank(); rank++) {
 
             if(impressionCounts.containsKey(rank)) {