From 4a88d666f359c6035b7fc150036c14e5e546272e Mon Sep 17 00:00:00 2001 From: Florian Rupprecht Date: Tue, 23 Jan 2024 18:34:29 -0500 Subject: [PATCH] Update cran-comments.md --- cran-comments.md | 55 +++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 50 insertions(+), 5 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index dacce20..df47a4e 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -5,12 +5,17 @@ ## R CMD check results There were no ERRORs or WARNINGs. -There was 1 NOTE: +> checking C++ specification ... NOTE + Specified C++14: please drop specification unless essential -* checking installed package size ... NOTE - installed size is 5.6Mb +C++14 is essential for this package. + +> checking installed package size ... NOTE + installed size is 9.6Mb sub-directories of 1Mb or more: - libs 5.4Mb + libs 8.4Mb + +This package uses larger libraries. ## httpgd @@ -22,7 +27,7 @@ After/if this package is accepted to CRAN, we will submit the new version of the # I recently received the following email from CRAN (for httpgd): > Prof Brian Ripley -> Wed, Jan 10, 1:51 PM (12 days ago) +> Wed, Jan 10, 1:51 PM (12 days ago) > to me, CRAN > > Dear maintainer, @@ -37,3 +42,43 @@ After/if this package is accepted to CRAN, we will submit the new version of the > The CRAN Team The clang 18 warnings have been addressed in this package. + +## Additional issues + +> Please always write package names, software names and API (application +> programming interface) names in single quotes in title and description. +> e.g: --> 'C' +> Please note that package names are case sensitive. + +'C' has been quoted in the description. + +> If there are references describing the methods in your package, please +> add these in the description field of your DESCRIPTION file in the form +> authors (year) +> authors (year) +> authors (year, ISBN:...) +> or if those are not available: +> with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for +> auto-linking. (If you want to add a title as well please put it in +> quotes: "Title") + +There are no references for this package. + +> Please add \value to .Rd files regarding exported methods and explain +> the functions results in the documentation. Please write about the +> structure of the output (class) and also what the output means. (If a +> function does not return a value, please document that too, e.g. +> \value{No return value, called for side effects} or similar) +> Missing Rd-tags: +> ugd_save_inline.Rd: \value +> ugd_test_pattern.Rd: \value +> +> \dontrun{} should only be used if the example really cannot be executed +> (e.g. because of missing additional software, missing API keys, ...) by +> the user. That's why wrapping examples in \dontrun{} adds the comment +> ("# Not run:") as a warning for the user. +> Please replace \dontrun with \donttest if possible. + +These have been addressed. + +Thank you! \ No newline at end of file