Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to oauth.py #21

Open
nwunderly opened this issue Sep 27, 2022 · 1 comment
Open

Improvements to oauth.py #21

nwunderly opened this issue Sep 27, 2022 · 1 comment
Labels
enhancement New feature or request hacktoberfest Hacktoberfest

Comments

@nwunderly
Copy link
Owner

oauth.py is a bit of a mess at the moment. It's meant to be an internal class, and it's essentially just a port of a requests-based implementation that I pulled from a Gist a while ago. It's in desperate need of some love.

Any improvements to the file are welcome, and will be accepted as PRs. This issue will remain open until the file is fully improved.

Some ideas:

  • rewrite internal functions that aren't used by starlette-discord to fix bugs we've missed
  • reformat or rewrite documentation for the class and its methods (see Fix inconsistent docstrings #20)
  • general QOL changes to the class or its attributes/methods (breaking API changes will need to be justified and documented)

This is a bit of a more complicated task. It's likely something I'll revisit in the coming months, and (if necessary) just rewrite from scratch myself. That said, any improvements to library internals are always welcome.

Happy Hacktoberfest!! 😄

@nwunderly nwunderly added enhancement New feature or request hacktoberfest Hacktoberfest labels Sep 27, 2022
@akhilsharmaa
Copy link

This seems interesting I would like to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants