Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update faculty / department emails for Course Details error reporting #3785

Open
kokrui opened this issue Aug 20, 2024 · 4 comments
Open

Update faculty / department emails for Course Details error reporting #3785

kokrui opened this issue Aug 20, 2024 · 4 comments

Comments

@kokrui
Copy link
Member

kokrui commented Aug 20, 2024

We have a "Report Errors" button on each Course Detail page. (See #3784)

However, some faculty emails listed there should be deprecated (e.g., GEQ1000, a course that no longer exists), and there are new emails which should be added.

We should incrementally improve this! If you notice data that should be added / removed / updated, please make a PR or issue to update https://github.com/nusmodifications/nusmods/blob/master/website/src/data/facultyEmail.json

@dasha3412
Copy link

Hi, I'd like to work on this

@itstrueitstrueitsrealitsreal
Copy link
Contributor

Hi, wanted to ask about how we wanna go about doing this, do we wanna remove all the departments that no longer exist and all the emails for courses that no longer exist? Having a little trouble deciding which to remove in my PR.

@kokrui
Copy link
Member Author

kokrui commented Feb 9, 2025

I think eventually we'd want to remove all unused emails, but I'd be happy to accept PRs that make any sort of incremental progress (e.g. removing one or the other or any subset)!

@itstrueitstrueitsrealitsreal
Copy link
Contributor

Sounds good, I'll start working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants