Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fulfill-order feature may not be CLI-oriented #766

Open
nus-pe-bot opened this issue Nov 16, 2024 · 1 comment
Open

fulfill-order feature may not be CLI-oriented #766

nus-pe-bot opened this issue Nov 16, 2024 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 16, 2024

In order to use fulfill-order, I'll first have to pull up view-orders and then use mouse to copy an order's UUID to finish the order. Maybe this feature can be more friendly for keyboard-only user?


[original: nus-cs2113-AY2425S1/pe-interim#758] [original labels: severity.Medium type.FeatureFlaw]
@cnivedit
Copy link

cnivedit commented Nov 17, 2024

Team's Response

As of v2.1, there is no in-built support to improve the efficiency of the specified workflow. The initial design was to assign a serial number to each order, however the presence of a serial number alongside a UUID was met with plenty of confusion by users during the PE dry run. Hence, we decided to switch to a UUID only approach as it is a more credible way to uniquely identify each order.

To work around this issue, the user may however utilize tools native to their choice of command line. For instance, windows users using command prompt or terminal may enter mark mode (default shortcut: ctrl + shift + m), navigate and copy the UUID purely using keyboard inputs.

Possible improvements to this feature may include

  1. An identifier implementation similar to git's commit hashes where the commit being referred to can be identified using prefix matching. This would however require a complete revamp of the identifier as commit hashes are inherently designed for prefix matching as the hash is generated from the contents of the commit itself. UUID on the other hand is unrelated to the contents of the order, they are globally unique but may often have overlapping prefixes, and hence unreliable or inefficient for prefix matching.
  2. Adding support for command line features such as piping, grep, awk within the PILL application

Due to the presence of other, more pressing functionalities to be implemented, both these improvements fall out of the scope of v2.1 as they are QoL improvements.

The issue severity has been downgraded to low as there are options on the user's end to continue using the application by utilizing features of their command line. Since the target audience as specified by the project constraints are users who are familiar and prefer using CLI, it is expected that very few users will face inconvenience utilizing these features.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants