Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicated entries with same name for cost and price plot #765

Open
nus-pe-bot opened this issue Nov 16, 2024 · 1 comment
Open

duplicated entries with same name for cost and price plot #765

nus-pe-bot opened this issue Nov 16, 2024 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 16, 2024

image.png

Visualize cost and price will show entries with the same name if they have different expiry date - however cost and price features only allow price set for all entries.

For large number of items, this plot could show up as clustered and redundant as we will see the same information multiple times. Maybe only show one entry for each item name?


[original: nus-cs2113-AY2425S1/pe-interim#757] [original labels: type.FeatureFlaw severity.Low]
@cxc0418
Copy link
Contributor

cxc0418 commented Nov 17, 2024

Team's Response

Thank you for highlighting the issue. It is designed to be like this. Since there are possibilities whereby a user might edit the saved file (txt file) data, in such circumstances, cost and price features can be different for every entry. Thus, to prevent these kinds of circumstances (the user modifies entries with the same name and different expiration dates to different costs/prices, and we do not show entries with the same name and different expiration dates, there will be a lack of data in the visualization), it is our design to keep all entries with the same name but different expiry dates in our visualizer.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants