Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The class diagram is too complex and does not show the ‘+’ and ‘-’ symbols. #754

Open
nus-pe-bot opened this issue Nov 16, 2024 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 16, 2024

Description
The class diagram is too complex and does not show the ‘+’ and ‘-’ symbols. Perhaps using the correct correspondence symbols would be more convincing?

Evidence
image.png


[original: nus-cs2113-AY2425S1/pe-interim#738] [original labels: severity.Medium type.DocumentationBug]
@rexkoh425
Copy link
Contributor

rexkoh425 commented Nov 17, 2024

Team's Response

Thank you for highlighting the problem of the symbol. This problem arose from our unfamiliarity of using plantUML and not understanding the possible commands to change this. Through more through research, we realised adding "skinparam classAttributeIconSize 0" could remove this unusual notation differently. We could have added a table to show the conversion in hindsight. However, we disagree that this issue should be a medium severity as it should be under the category of notation variations and the accuracy of the diagram remains. Complexity of the diagram has already been simplified by emptying other less important classes as said in the notes and we feel any further simplification would severely decrease reader's understanding of our class diagram like removing methods.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants