Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entered in invalid date but was still added into sleep list #2563

Open
nus-se-script opened this issue Apr 19, 2024 · 1 comment
Open

Entered in invalid date but was still added into sleep list #2563

nus-se-script opened this issue Apr 19, 2024 · 1 comment

Comments

@nus-se-script
Copy link

nus-se-script commented Apr 19, 2024

image.png

Entered 31/02/2000 into command line, expected error message but it added 29/02/2000 into sleep list


[original: nus-cs2113-AY2324S2/pe-interim#2554] [original labels: type.FunctionalityBug severity.Medium]
@OKW32
Copy link
Contributor

OKW32 commented Apr 20, 2024

Team's Response

Accepted that this is of medium severity, but this is a feature flaw, as instead of adding the hours to an invalid sleep cycle, we have assigned it to a nearer date, if the day is between 1-31.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants