Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split RuntimeFramework into separate RuntimeFramework and TargetFramework classes #406

Closed
ChrisMaddock opened this issue Apr 22, 2018 · 2 comments
Assignees

Comments

@ChrisMaddock
Copy link
Member

ChrisMaddock commented Apr 22, 2018

This has come out of #394.

The RuntimeFramework functionality is one of the more legacy areas of our code base - and could use a refactor to better fit the NUnit 3 architecture.

RuntimeFramework is currently used for two purposes, both to detect available runtimes (e.g. full framework, mono, CF), and to determine the target framework of an assembly (e.g net45, netcore20). There's something of a mismatch here as a net45 could of course run on .NET Framework or Mono, so the Runtime.Any enum exists. (Although it's not technically 'Any' I don't believe, as this bit of code still supports Silverlight and CF!)

With supporting .NET Standard and .NET Core for #394 and #271, this bit of codes going to need some additional complexity. Accordingly, I'd like to refactor and do the following:

  1. Refactor for thread-safety and proper division of RuntimeFrameworkService and RuntimeFramework responsibilities (As Refactor RuntimeFramework to ensure thread-safety #173)
  2. Remove all support for Silverlight and CF. (I think this class used to be shared with NUnit Framework? Or was it that the NUnit 2 console supported these platforms?)
  3. Split out separate classes for 'runtime' (e.g. full framework, mono, .NET Core) and 'target' (.NET, .NET Standard etc.)

Any thoughts? 🙂

@ChrisMaddock ChrisMaddock self-assigned this Apr 22, 2018
@rprouse
Copy link
Member

rprouse commented Apr 24, 2018

All good by me 😀

@ChrisMaddock
Copy link
Member Author

ChrisMaddock commented Oct 25, 2019

Superceeded by #702 - I think unfortunately the problem is a little bigger than this one class 😭 Everything listed here, I expect to still be included within #702.

@ChrisMaddock ChrisMaddock added this to the Closed Without Action milestone Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants