You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The RuntimeFramework functionality is one of the more legacy areas of our code base - and could use a refactor to better fit the NUnit 3 architecture.
RuntimeFramework is currently used for two purposes, both to detect available runtimes (e.g. full framework, mono, CF), and to determine the target framework of an assembly (e.g net45, netcore20). There's something of a mismatch here as a net45 could of course run on .NET Framework or Mono, so the Runtime.Any enum exists. (Although it's not technically 'Any' I don't believe, as this bit of code still supports Silverlight and CF!)
With supporting .NET Standard and .NET Core for #394 and #271, this bit of codes going to need some additional complexity. Accordingly, I'd like to refactor and do the following:
Remove all support for Silverlight and CF. (I think this class used to be shared with NUnit Framework? Or was it that the NUnit 2 console supported these platforms?)
Split out separate classes for 'runtime' (e.g. full framework, mono, .NET Core) and 'target' (.NET, .NET Standard etc.)
Any thoughts? 🙂
The text was updated successfully, but these errors were encountered:
Superceeded by #702 - I think unfortunately the problem is a little bigger than this one class 😭 Everything listed here, I expect to still be included within #702.
This has come out of #394.
The RuntimeFramework functionality is one of the more legacy areas of our code base - and could use a refactor to better fit the NUnit 3 architecture.
RuntimeFramework is currently used for two purposes, both to detect available runtimes (e.g. full framework, mono, CF), and to determine the target framework of an assembly (e.g net45, netcore20). There's something of a mismatch here as a net45 could of course run on .NET Framework or Mono, so the Runtime.Any enum exists. (Although it's not technically 'Any' I don't believe, as this bit of code still supports Silverlight and CF!)
With supporting .NET Standard and .NET Core for #394 and #271, this bit of codes going to need some additional complexity. Accordingly, I'd like to refactor and do the following:
Any thoughts? 🙂
The text was updated successfully, but these errors were encountered: