From 4a455b314cdea32d1b025ac8ea6c163e280e5975 Mon Sep 17 00:00:00 2001 From: Mat Jordan <mat@northwestern.edu> Date: Mon, 16 Sep 2024 15:42:13 -0400 Subject: [PATCH] Timeout :( --- .github/workflows/playwright.yml | 1 + pages/items/[id].tsx | 1 - playwright.config.ts | 8 ++++---- tests/work.spec.ts | 3 --- 4 files changed, 5 insertions(+), 8 deletions(-) diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml index 27fa7707..6bbd05a2 100644 --- a/.github/workflows/playwright.yml +++ b/.github/workflows/playwright.yml @@ -35,6 +35,7 @@ jobs: run: npx playwright test env: BASE_URL: ${{ secrets.BASE_URL }} + NEXT_PUBLIC_DCAPI_ENDPOINT: ${{ secrets.NEXT_PUBLIC_DCAPI_ENDPOINT }} - uses: actions/upload-artifact@v4 if: ${{ !cancelled() }} diff --git a/pages/items/[id].tsx b/pages/items/[id].tsx index cc15eaeb..344027b4 100644 --- a/pages/items/[id].tsx +++ b/pages/items/[id].tsx @@ -97,7 +97,6 @@ const WorkPage: NextPage<WorkPageProps> = ({ title={work?.title || ""} description={work ? buildWorkDescription(work) : ""} > - <div data-testid="example-toss">{id}</div> {!isLoading && work && manifest && ( <WorkProvider initialState={{ manifest: manifest, work: work }}> <ErrorBoundary FallbackComponent={ErrorFallback}> diff --git a/playwright.config.ts b/playwright.config.ts index e85cfe31..e922c7ad 100644 --- a/playwright.config.ts +++ b/playwright.config.ts @@ -14,13 +14,13 @@ export default defineConfig({ fullyParallel: false, /* Increase locator timeout past default 5s */ - expect: { - timeout: 30000, - }, + // expect: { + // timeout: 30000, + // }, /* Fail the build on CI if you accidentally left test.only in the source code. */ forbidOnly: !!process.env.CI, reporter: "html", - timeout: 30000, + // timeout: 30000, /* Retry on CI only */ retries: process.env.CI ? 2 : 0, /* Opt out of parallel tests on CI. */ diff --git a/tests/work.spec.ts b/tests/work.spec.ts index 16926787..769f9c1e 100644 --- a/tests/work.spec.ts +++ b/tests/work.spec.ts @@ -53,9 +53,6 @@ test.describe("Work page component", async () => { }); test("renders the Work top level metadata", async ({ page, workPage }) => { - await expect(page.getByTestId("example-toss")).toContainText( - CANARY_WORK_ID, - ); await expect(page.getByTestId("title")).toContainText( canaryWork.title || "", );