Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to add example choosing k to the vignette #3

Open
lcolladotor opened this issue Feb 10, 2022 · 2 comments
Open

Suggestion to add example choosing k to the vignette #3

lcolladotor opened this issue Feb 10, 2022 · 2 comments

Comments

@lcolladotor
Copy link

Hi,

This is a great package! As you mention on the vignette, computing dist() can take (a) take a long time and (b) lots of memory. Abby @abspangler13 and I were considering using https://github.com/alexeckert/parallelDist/blob/master/R/parDist.R#L23 to resolve (a) but we would still be limited by (b). In particular if we computed a distance matrix across 100k spots in a Visium dataset (approx 75 GB of RAM: 1e5 * 1e5 * 8 / 1024^3 = 74.50581).

That led us to your work and well, something we noticed was missing from the vignette is an example where you choose a given k like they do in the following image from https://medium.com/codesmart/r-series-k-means-clustering-silhouette-794774b46586.

We thought that adding such an example might be useful for users like us.

Best,
Leo

@stephaniehicks
Copy link
Collaborator

Hi @lcolladotor @abspangler13, thanks for your interested in H+! This is a great suggestion, I'll work towards that. In the mean time, we created a similar plot in Figure 5 of our paper (https://doi.org/10.1101/2022.02.03.479015).

The code for it is here: https://github.com/stephaniehicks/fasthpluspaper/blob/96c89b7e304d7846130fefb0068cd777bfc3e2ae/scripts/05_supp02-application_plots.R#L59

@lcolladotor
Copy link
Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants