From ca702cff5f3d0947b317e3edd0967e4565d1062f Mon Sep 17 00:00:00 2001 From: Nihar Kapasi Date: Sun, 19 Jan 2025 10:39:55 +0530 Subject: [PATCH] wifi: Fix documentation on WifiPhy traces --- src/wifi/model/wifi-phy.cc | 2 +- src/wifi/model/wifi-phy.h | 15 ++++++++++++--- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/wifi/model/wifi-phy.cc b/src/wifi/model/wifi-phy.cc index 10f5b5d0ed..00c4a2cb71 100644 --- a/src/wifi/model/wifi-phy.cc +++ b/src/wifi/model/wifi-phy.cc @@ -351,7 +351,7 @@ WifiPhy::GetTypeId() "Trace source indicating a packet " "has been dropped by the device during reception", MakeTraceSourceAccessor(&WifiPhy::m_phyRxDropTrace), - "ns3::Packet::TracedCallback") + "ns3::WifiPhy::PhyRxDropTracedCallback") .AddTraceSource("PhyRxPpduDrop", "Trace source indicating a ppdu " "has been dropped by the device during reception", diff --git a/src/wifi/model/wifi-phy.h b/src/wifi/model/wifi-phy.h index d7a0b6761f..510339bc6f 100644 --- a/src/wifi/model/wifi-phy.h +++ b/src/wifi/model/wifi-phy.h @@ -746,14 +746,23 @@ class WifiPhy : public Object typedef void (*PhyRxPayloadBeginTracedCallback)(WifiTxVector txVector, Time psduDuration); /** - * TracedCallback signature for start of PSDU reception events. + * TracedCallback signature for PhyRxPpduDrop trace source. * - * @param txVector the TXVECTOR decoded from the PHY header - * @param psduDuration the duration of the PSDU + * @param ppdu the ppdu being received + * @param reason the reason the ppdu was dropped */ typedef void (*PhyRxPpduDropTracedCallback)(Ptr ppdu, WifiPhyRxfailureReason reason); + /** + * TracedCallback signature for PhyRxDrop trace source. + * + * @param packet the packet being received + * @param reason the reason the packet was dropped + */ + typedef void (*PhyRxDropTracedCallback)(Ptr packet, + WifiPhyRxfailureReason reason); + /** * TracedCallback signature for end of MAC header reception events. *