Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's really easy to forget to put #16

Open
DamonOehlman opened this issue Mar 29, 2015 · 3 comments
Open

It's really easy to forget to put #16

DamonOehlman opened this issue Mar 29, 2015 · 3 comments

Comments

@DamonOehlman
Copy link
Contributor

Scenario:

  • Monday Morning
  • A little bit stupid
  • Stored things in the varhash using varhash.set rather than varhash.put
  • Scratched head for a while
  • Drank coffee
  • Remembered to put and everything is ok again.

Just wondering if there is anything we can do to protect me from my next Monday morning 😺
@nrw
Copy link
Owner

nrw commented Mar 30, 2015

should we throw/warn if the argument passed to set is a string (as varhash should be an object)? @Raynos @neonstalwart @kumavis

@Raynos
Copy link
Contributor

Raynos commented Mar 30, 2015

@nrw 👍

The argument should be an object; never a string.

@DamonOehlman
Copy link
Contributor Author

Sweet - that should make next Monday way more awesome :)

DamonOehlman added a commit to DamonOehlman/observ-users that referenced this issue Apr 6, 2015
@DamonOehlman
put you idiot, put (ref nrw/observ-varhash#16)
bb9a70b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Raynos @DamonOehlman @nrw