Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issue in the definition of create_models, pilco/controllers.py(P1) #59

Open
DLPerf opened this issue Aug 21, 2021 · 0 comments
Open

Performance issue in the definition of create_models, pilco/controllers.py(P1) #59

DLPerf opened this issue Aug 21, 2021 · 0 comments

Comments

@DLPerf
Copy link

DLPerf commented Aug 21, 2021

Hello, I found a performance issue in the definition of create_models, pilco/controllers.py, tf.ones will be calculated repeatedly during program execution, resulting in reduced efficiency. I think it should be created before the loop.

The same issue exists in tf.ones in line 31 and tf.ones in line 19.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.
@DLPerf DLPerf changed the title Performance issue in the definition of create_models, pilco/controllers.py Performance issue in the definition of create_models, pilco/controllers.py(P1) Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DLPerf