Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename diff analyzer args #267

Closed
adisos opened this issue Nov 9, 2023 · 0 comments · Fixed by #268
Closed

Rename diff analyzer args #267

adisos opened this issue Nov 9, 2023 · 0 comments · Fixed by #268

Comments

@adisos
Copy link
Collaborator

adisos commented Nov 9, 2023 •
edited
Loading

  • Rename DiffAnalyzer API args from Dir1, Dir2 to be Ref1, Ref2 , including default arg names in output and log as ref1, ref2
  • Add new API option to DiffAnalyzer WithArgNames , allowing to change those arg names (will affect log messages and output reports).
  • Keep the cli cmd diff with arg names dir1, dir2
This was linked to pull requests Nov 9, 2023
Rename diff args #266
Closed
Rename diff args new #268
Merged
@adisos adisos mentioned this issue Nov 9, 2023
Merged
@adisos adisos changed the title Rename diff cmd args Rename diff analyzer arg names Nov 9, 2023
@adisos adisos changed the title Rename diff analyzer arg names Rename diff analyzer args Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename diff args new np-guard/netpol-analyzer
Rename diff args np-guard/netpol-analyzer
1 participant
@adisos