Featured collections should only include public visibility collections

[jillpe]

Summary

When clicking the 'View all collections' button from the home page, directs the user to a search results page that does not contain all of the facets and the facets are not styled the same as HykuCommons.

The above-described facet-limitation is expected behavior, as facets only appear if there is content faceted for the subset of search data. However, additional issues exist with the collections on the homepage, as updated in the details below.

Recordings

Knapsack

Screen.Recording.2024-10-09.at.9.59.38.AM.mov

HykuCommons

Screen.Recording.2024-10-09.at.10.01.21.AM.mov

Details

Featured collections should ONLY be public collections.

• The featured collections button should not appear if a collection is not public visibility.
• Changing a featured collection from public to private should also unfeature the collection.

Acceptance Criteria

• As a user, when I click the 'view all collections' button on the home page, it takes me to a catalog search with the collections faceted, which includes all of the collections that the user is able to see: only public if not logged in, authorized if logged in, and private only if they are the user's.
• The "feature" button appears as an option only on a public collection
• When a collection is changed from public, the collection is automatically checked and unfeatured if applicable.
• Facets are styled appropriately.

Testing Instructions

• Create a public collection
• Feature the collection
• Set the collection to private
• Observe that you can no longer feature the collection
• Check that the collection is no longer featured

[kirkkwang]

Verified that on all themes, clicking the "View all collections" button takes the user to
/catalog?f%5Bgeneric_type_sim%5D%5B%5D=Collection&locale=en when activates the facet for only showing collection

[sjproctor]

QA Results: ✅ Pass

The View all collections button on the home page takes the user to /catalog?f%5Bgeneric_type_sim%5D%5B%5D=Collection&locale=en where only collections are displayed. This is true on all four themes.

Default Theme

Cultural Theme

Institutional Theme

Neutral Theme

[ndroark]

Should I be concerned that in https://au-archives.palni-palci-staging.notch8.cloud/catalog?f%5Bgeneric_type_sim%5D%5B%5D=Collection&locale=en, only two collections show when I select the "Show All Collections" button?

[ShanaLMoore]

Should I be concerned that in https://au-archives.palni-palci-staging.notch8.cloud/catalog?f%5Bgeneric_type_sim%5D%5B%5D=Collection&locale=en, only two collections show when I select the "Show All Collections" button?

When logged out we can only see 2 collections because only 2 are public. If you log in you can see more. Let us know if you expect something different though.

logged in as support@notch8:

[ShanaLMoore]

However, the thing I'm noticing that may be a bug is seeing featured collections display private works when the user is logged out. When they click on them they can't see anything without logging in, but I'd think they shouldn't see them in the featured collections to click on them to begin with.

LaRita will make a separate ticket for this issue if you agree it's undesirable behavior. cc @ndroark Or rather, we should confirm the behavior against prod before calling it a bug.

[laritakr]

Since this ticket didn't have any work done on it, I will just clarify the situation so we can duplicate it for testing and update the description. It will be moved back to ready for development status.

[ndroark]

The private collections are still featured and visible on the homepage to logged out users. My hunch is that these odd behaviors are artifacts of the import process, since the collections were set to public on the repository before it was ported over.

[laritakr]

Thanks Nic... You may be correct that it is because of the import process. In the production demo site, a collection is automatically unfeatured if it is changed to private.

We do need to verify that the unfeaturing is happening correctly, and that the feature button only shows on public objects. This may not have carried over as we valkyrized, so we want to make sure it works correctly.

[kirkkwang]

Private collection does not have a feature button

Public collection does have a feature button

I've also confirmed that setting a collection to private removes it as a featured collection.

[ShanaLMoore]

QA RESULTS: ✅ PASS

tested on STAGING

Testing Instructions

• Create a public collection
• Feature the collection

• Set the collection to private
• Observe that you can no longer feature the collection

• Check that the collection is no longer featured

[ndroark]

Is this expected to work retroactively? I still see collections featured on the https://au-archives.palni-palci-staging.notch8.cloud/ homepage that are set to private.

[kirkkwang]

@ndroark This one is strange, somehow it got featured and it seemingly stuck that way perhaps? When I click on the private collection, there isn't a button to unfeature it (because there it should be featureable in the first place). So I'm wondering if we need to set up a script to check each tenant for its featured collections and remove it if they are privaet.

[ndroark]

That makes sense, and I think of it as very low priority. I think it would be fine to put this ticket to deploy and create a future maintenance ticket for the script function.

[laritakr]

I believe there may have been issues from some past attempts to bring data over from production, where permissions didn't get set correctly on some items. I wouldn't expect to see similar issues in production but we can definitely create a simple script if we find it necessary.