Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failing specs #933

Open
ShanaLMoore opened this issue Dec 7, 2023 · 0 comments
Open

Fix CI failing specs #933

ShanaLMoore opened this issue Dec 7, 2023 · 0 comments

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Dec 7, 2023 •
edited
Loading

PALS pipeline always fails on the same 5 specs. We've grown accustomed to this, which isn't ideal. Had I not looked into the spec failures of one of my PRs, I wouldn't have known that I introduced a valid bug.

I've never been able to get these specs to fail locally.

I've commented out these specs for now and am creating this ticket so that we can address them at a later time. At least our pipeline will be green again and more trustworthy.

SPECS:

  1. spec/features/feature_flag_spec.rb
  2. spec/features/admin_dashboard_spec.rb:14

Image
ShanaLMoore pushed a commit that referenced this issue Dec 7, 2023
✅ Skip specs consistently failing on CI pipeline
b06897c 
These specs consistently fail the pipeline, and we typically ignore them. When a valid bug was introduced we could've easily missed it. This commit skips these specs in favor of a green pipeline. A ticket has been created to document and investigate it at a later time.

Issue:
- #933
@ShanaLMoore ShanaLMoore mentioned this issue Dec 7, 2023
Merged
@laritakr laritakr mentioned this issue Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ShanaLMoore