Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tenant-based conditional rendering for top-right "Login" link #891

Open
12 tasks
jeremyf opened this issue Oct 30, 2023 · 1 comment
Open
12 tasks

Add tenant-based conditional rendering for top-right "Login" link #891

jeremyf opened this issue Oct 30, 2023 · 1 comment
Assignees

Comments

@jeremyf
Copy link
Contributor

jeremyf commented Oct 30, 2023

From @ndroark

  1. Have Hyku staff using the ReShare Hyku model be trained to use the Administrator login at the bottom of the UI to access staff functionality.
  2. For ReShare use only, remove the Login at the top right hand corner as that login is linked to patrons accessing Hyku and with ReShare patrons will not be accessing their digital loans that way - they will come in from an already authenticated ReShare point which passes that to Hyku for them to access the doc.

As part of conversation: https://assaydepot.slack.com/archives/C0313NKC08L/p1697646938457559

Acceptance Criteria

  • Add a tenant based feature flipper to say "Show General Login Link at Top Right of Page"; by default this is on. For Reshare we will instruct them to turn that feature off.

Screenshot

Image

Testing

Test combinations of flipper status, show page theme, and type of user

Turn Flipper on or off: log in as admin user, navigate to admin/features, toggle flipper
Reshare on or off: log in as admin user, navigate to admin/appearance, themes tab, and Select via Show Page Theme
Log on or off: use options in footer if hidden from top right menu

Flipper On, Reshare On, Admin User

  • Log in as an admin user
  • Select Reshare theme & verify flipper is on
  • Navigate to home, dashboard, catalog search, work show, and collection show pages
    • All pages show normal links in top-right

Flipper off, Reshare On, Admin User

  • Turn flipper off
  • Navigate to home, dashboard, catalog search, work show, and collection show pages
    • All pages show normal links in top-right

Flipper off, Reshare Off, Admin User

  • Switch to a show theme other than Reshare
  • Navigate to home, dashboard, catalog search, work show, and collection show pages
    • All pages show normal links in top-right

Flipper off, Reshare Off, no user

  • Logoff
  • Navigate to home, dashboard, catalog search, work show, and collection show pages
    • There is no login option at top right... only language dropdown appears

Flipper off, Reshare Off, non-admin user

  • Log in as non-admin user
  • Navigate to home, dashboard, catalog search, work show, and collection show pages
    • All pages show only dashboard link
  • Log off

Flipper off, Reshare On, non-admin user

  • Log on as admin user
  • Switch to Reshare show page theme
  • Log off
  • Log in as non-admin user
  • Navigate to home, dashboard, catalog search, work show, and collection show pages
    • Work show page has only language dropdown
    • All other pages show only dashboard link
  • Log off

Flipper on, Reshare On, non-admin user

  • Log on as admin user
  • Turn flipper on
  • Log off
  • Log in as non-admin user
  • Navigate to home, dashboard, catalog search, work show, and collection show pages
    • Work show page has only language dropdown
    • All other pages show only dashboard link
  • Log off

Flipper on, Reshare Off, non-admin user

  • Log on as admin user
  • Switch to non-Reshare show page theme
  • Log off
  • Log in as non-admin user
  • Navigate to home, dashboard, catalog search, work show, and collection show pages
    • Work show page has only language dropdown
    • All other pages show normal links
Sample Screenshots after changes

With Flipper on

Reshare show page, non-admin

Screenshot 2023-11-03 at 3 12 16 PM

Reshare show page, admin

Screenshot 2023-11-03 at 3 13 53 PM

With Flipper off

Reshare show page, non-admin

Screenshot 2023-11-03 at 3 19 47 PM

Reshare show page, admin

Screenshot 2023-11-03 at 3 13 53 PM

Home page, not logged in

Screenshot 2023-11-03 at 3 16 48 PM

Home page, admin

Screenshot 2023-11-03 at 3 17 46 PM

Home page, non-admin

Screenshot 2023-11-03 at 3 18 41 PM

@jeremyf jeremyf moved this to Ready for Development in palni-palci Oct 30, 2023
@laritakr laritakr self-assigned this Nov 1, 2023
@ShanaLMoore ShanaLMoore moved this from Ready for Development to SoftServ QA in palni-palci Nov 6, 2023
@kirkkwang
Copy link
Contributor

kirkkwang commented Nov 6, 2023

QA RESULTS ✅

Feature flipper option is present
image

When it's off I don't see a login link at the top
image

When it's on i see the login link
image

@kirkkwang kirkkwang moved this from SoftServ QA to ReShare QA in palni-palci Nov 6, 2023
@ndroark ndroark moved this from ReShare QA to Deploy to Production in palni-palci Nov 7, 2023
@ShanaLMoore ShanaLMoore moved this from Deploy to Production to Client Verification in palni-palci Nov 9, 2023
@ndroark ndroark moved this from Client Verification to Done in palni-palci Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants