-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Favicon to Hyku Commons homepage #829
Labels
Comments
This functionality is already there? See here Were there additional features you were hoping would be a part of that? |
We have that functionality for each tenant, but not for the Hyku Commons homepage itself. I don't think we actually care about superadmins having the ability to change it, we would just like to add one through the html. |
@ndroark Can you share the fav icon image with us? |
laritakr
pushed a commit
that referenced
this issue
Mar 8, 2024
laritakr
pushed a commit
that referenced
this issue
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Pals would like to be able to have a home page favicon for [Hyku Commons[(https://hykucommons.org/) set up through html.
Tasks
The
app/helpers/hyrax_helper.rb
has afavicon
method; which does not appear to be called inapp/views/_head_tag_extras.html.erb
norapp/views/hyrax/homepage/browserconfig.xml.erb
. Consider leveraging the helper method to handle favicon switching so that we're not relying so much on theSite&.favicon&.url()
idiom; and instead goingfavicon&.url()
. (Note this is conjecture by Jeremy)favicon
helper method instead of the chained methods of the above views.Site
(e.g. we're on the proprietor page), use the hard-coded proprietor faviconAcceptance Criteria
Testing Instructions
Navigate to proprietor homepage. Icon should show on tab.
The text was updated successfully, but these errors were encountered: