Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Favicon to Hyku Commons homepage #829

Open
4 tasks
ndroark opened this issue Sep 28, 2023 · 5 comments
Open
4 tasks

Add Favicon to Hyku Commons homepage #829

ndroark opened this issue Sep 28, 2023 · 5 comments
Assignees
Labels
Holiday Sprint maintenance bills to maintenance

Comments

@ndroark
Copy link
Collaborator

ndroark commented Sep 28, 2023

Summary

Pals would like to be able to have a home page favicon for [Hyku Commons[(https://hykucommons.org/) set up through html.

Tasks

The app/helpers/hyrax_helper.rb has a favicon method; which does not appear to be called in app/views/_head_tag_extras.html.erb nor app/views/hyrax/homepage/browserconfig.xml.erb. Consider leveraging the helper method to handle favicon switching so that we're not relying so much on the Site&.favicon&.url() idiom; and instead going favicon&.url(). (Note this is conjecture by Jeremy)

  • Review feasibility of using the favicon helper method instead of the chained methods of the above views.
  • Add the hard-coded proprietor favicon to the repository
  • For cases where there's no Site (e.g. we're on the proprietor page), use the hard-coded proprietor favicon

Acceptance Criteria

Testing Instructions

Navigate to proprietor homepage. Icon should show on tab.

@ndroark ndroark converted this from a draft issue Sep 28, 2023
@jillpe
Copy link

jillpe commented Nov 30, 2023

This functionality is already there? See here Were there additional features you were hoping would be a part of that?

@ndroark
Copy link
Collaborator Author

ndroark commented Dec 1, 2023

We have that functionality for each tenant, but not for the Hyku Commons homepage itself. I don't think we actually care about superadmins having the ability to change it, we would just like to add one through the html.

@jillpe
Copy link

jillpe commented Dec 1, 2023

@ndroark Can you share the fav icon image with us?

@ndroark
Copy link
Collaborator Author

ndroark commented Dec 11, 2023

Image

@jillpe jillpe added the maintenance bills to maintenance label Feb 27, 2024
laritakr pushed a commit that referenced this issue Mar 8, 2024
laritakr pushed a commit that referenced this issue Mar 8, 2024
@laritakr laritakr moved this from Ready for Development to Deploy to Staging in palni-palci Mar 8, 2024
@laritakr laritakr self-assigned this Mar 8, 2024
@laritakr laritakr moved this from Deploy to Staging to SoftServ QA in palni-palci Mar 11, 2024
@laritakr
Copy link
Contributor

✅ Passes QA

Image

@ShanaLMoore ShanaLMoore moved this from SoftServ QA to PALs QA in palni-palci Mar 11, 2024
@ndroark ndroark moved this from PALs QA to Deploy to Production in palni-palci Mar 13, 2024
@jillpe jillpe moved this from Deploy to Production to Client Verification in palni-palci Mar 18, 2024
@ndroark ndroark moved this from Client Verification to Done in palni-palci Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Holiday Sprint maintenance bills to maintenance
Projects
Status: Done
Development

No branches or pull requests

3 participants