-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathreview_changed.txt
123 lines (123 loc) · 9.02 KB
/
review_changed.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
Δ spec/spec_helper.rb::deferred
Δ spec/tasks/rake_spec.rb::deferred
Δ spec/forms/hyrax/forms/permission_template_form_spec.rb::deferred
Δ spec/forms/hyrax/generic_work_form_spec.rb::deferred
Δ spec/features/collection_spec.rb::deferred
Δ spec/features/create_work_spec.rb::deferred
Δ spec/features/collection_type_spec.rb::deferred
Δ spec/features/edit_work_spec.rb::deferred
Δ spec/models/collection_spec.rb::deferred
Δ spec/models/content_block_spec.rb::deferred
Δ spec/models/hyrax/group_spec.rb::deferred
Δ spec/models/user_spec.rb::deferred
Δ spec/presenters/hyrax/admin/workflow_roles_presenter_spec.rb::deferred
Δ spec/presenters/hyrax/iiif_manifest_presenter_spec.rb::deferred
Δ spec/abilities/collection_ability_spec.rb::deferred
Δ spec/support/rake.rb::deferred
Δ spec/factories/admin_sets.rb::deferred
Δ spec/factories/object_id.rb::deferred
Δ spec/factories/file_sets.rb::deferred
Δ spec/factories/generic_works.rb::deferred
Δ spec/factories/workflow_actions.rb::deferred
Δ spec/factories/collection_type_participants.rb::deferred
Δ spec/factories/content_blocks.rb::deferred
Δ spec/factories/collection_types.rb::deferred
Δ spec/factories/workflows.rb::deferred
Δ spec/factories/collections.rb::deferred
Δ spec/factories/permission_template_accesses.rb::deferred
Δ spec/factories/users.rb::deferred
Δ spec/factories/permission_templates.rb::deferred
Δ spec/actors/hyrax/actors/generic_work_actor_spec.rb::deferred
Δ spec/controllers/catalog_controller_spec.rb::deferred
Δ spec/controllers/hyrax/homepage_controller_spec.rb::deferred
Δ spec/controllers/hyrax/admin/appearances_controller_spec.rb::deferred
Δ spec/controllers/hyrax/generic_works_controller_spec.rb::deferred
Δ spec/controllers/hyrax/content_blocks_controller_spec.rb::deferred
Δ spec/views/hyrax/admin/users/index.html.erb_spec.rb::deferred
Δ spec/views/hyrax/dashboard/collections/_form_share_table.html.erb_spec.rb::deferred
Δ spec/views/hyrax/dashboard/collections/_form_share.erb_spec.rb::deferred
Δ spec/views/_user_util_links.html.erb_spec.rb::deferred
Δ spec/views/content_blocks/edit.html.erb_spec.rb::deferred
Δ spec/rails_helper.rb::deferred
Δ spec/helpers/hyrax_helper_spec.rb::deferred
Δ spec/services/hyrax/quick_classification_query_spec.rb::deferred
Δ spec/services/hyrax/thumbnail_path_service_spec.rb::deferred
Δ app/mailers/hyrax/contact_mailer.rb::Consider renaming HykuMailer to ApplicationMailer
Δ app/models/content_block.rb::address deprecation
Δ app/models/hyrax/group.rb::maybe permission template issues
Δ app/models/featured_work.rb::Todo a double_combo add class_attribute to Hyrax, we can make it configurable, configure in Hyku
Δ app/models/concerns/hyrax/ability/solr_document_ability.rb::functionality is right, improve documentation
Δ app/models/concerns/hyrax/ability/collection_ability.rb::needs a deliberate review
Δ app/presenters/hyrax/admin/users_presenter.rb::convert to decorator
Δ app/controllers/hyrax/homepage_controller.rb::here there be dragons, isolate collection queries that require extensive changes
Δ app/controllers/concerns/hyrax/admin/users_controller_behavior.rb::ok
Δ app/views/_head_tag_extras.html.erb::ok
Δ app/views/_logo.html.erb::ok
Δ app/views/catalog/_index_header_list_collection.html.erb::ok
Δ app/views/catalog/_index_header_list_default.html.erb::ok but maybe revisit h3 vs h4
Δ app/views/catalog/_thumbnail_list_collection.html.erb::review override
Δ app/views/catalog/_index_gallery_collection_wrapper.html.erb::review override
Δ app/views/_user_util_links.html.erb::ok but as we log in and now we'll see if it's working, revisit ml-auto vs navbar-dark, pay attention to UI notification
Δ app/views/shared/_appearance_styles.html.erb::ok
Δ app/views/shared/_footer.html.erb::review ui footer classes
Δ app/views/_masthead.html.erb::ok
Δ app/views/layouts/hyrax.html.erb::revisit content_for(:container_header), we might want to bring that in
Δ app/views/layouts/homepage.html.erb::add block_for(name: 'banner_image_text') to Hyrax and remove this, perhaps
Δ app/views/hyrax/batch_edits/_delete_selected.html.erb::revisit permissions and hidden class, do we even see it?
Δ app/views/hyrax/homepage/_featured_fields.html.erb::ok
Δ app/views/hyrax/homepage/_explore_collections.html.erb::check the parent rendering view for table
Δ app/views/hyrax/homepage/_recent_document.html.erb::ok
Δ app/views/hyrax/homepage/_home_content.html.erb::ok
Δ app/views/hyrax/contact_form/new.html.erb::ok
Δ app/views/hyrax/admin/collection_types/_form_participant_table.html.erb::maybe ok, needs revisiting, check functionality
Δ app/views/hyrax/admin/collection_types/_form_participants.html.erb::contribute back translations
Δ app/views/hyrax/admin/workflow_roles/index.html.erb::probably okay, just need to test
Δ app/views/hyrax/admin/admin_sets/_form_participant_table.html.erb::should be okay, revisit comment on ln23
Δ app/views/hyrax/admin/admin_sets/_form_participants.html.erb::verify behavior works
Δ app/views/hyrax/admin/appearances/show.html.erb::ok
Δ app/views/hyrax/admin/users/index.html.erb::ok
Δ app/views/hyrax/admin/stats/show.html.erb::review hyrax implementation
Δ app/views/hyrax/uploads/_js_templates_branding.html.erb::ok
Δ app/views/hyrax/dashboard/sidebar/_activity.html.erb::ok
Δ app/views/hyrax/dashboard/sidebar/_configuration.html.erb::ok
Δ app/views/hyrax/dashboard/sidebar/_repository_content.html.erb::ok
Δ app/views/hyrax/dashboard/sidebar/_tasks.html.erb::ok
Δ app/views/hyrax/dashboard/_sidebar.html.erb::contribute the 17-22 to add title
Δ app/views/hyrax/dashboard/works/_list_works.html.erb::contribute entire view back
Δ app/views/hyrax/dashboard/collections/_show_add_items_actions.html.erb::ok
Δ app/views/hyrax/dashboard/collections/_show_document_list_row.html.erb::ok
Δ app/views/hyrax/dashboard/collections/_show_actions.html.erb::ok
Δ app/views/hyrax/dashboard/collections/_form_discovery.html.erb::ok
Δ app/views/hyrax/dashboard/collections/_form_share_table.html.erb::ok
Δ app/views/hyrax/dashboard/collections/_list_collections.html.erb::contribute back, add new translation in hyrax (hyrax.dashboard.my.sr.collections_batch_checkbox)
Δ app/views/hyrax/dashboard/collections/_subcollection_list.html.erb::consider adding manage items in collection ability that echoes the edit ability to Hyrax
Δ app/views/hyrax/dashboard/collections/_show_parent_collection_row.html.erb::consider adding manage items in collection ability that echoes the edit ability to Hyrax
Δ app/views/hyrax/dashboard/collections/_form_branding.html.erb::ok
Δ spec/models/solr_document_spec.rb::deferred
Δ spec/controllers/hyrax/my/collections_controller_spec.rb::deferred
Δ spec/views/hyrax/base/_relationships.html.erb_spec.rb::deferred
Δ app/views/hyrax/file_sets/media_display/_pdf.html.erb::we may need to add the link_to for the download
Δ app/views/hyrax/file_sets/_actions.html.erb::contribute "caret" back, need to add from Hyrax dropdown-item classes for <li> tags
Δ app/views/hyrax/admin/features/index.html.erb::change panel and panel-body to card and card-body ln 11-12
Δ app/views/hyrax/dashboard/collections/_form_share.html.erb::ok
Δ app/views/hyrax/dashboard/collections/_form.html.erb::possible contribute back to hyrax, Hyku has the ability to add a specific image for Collections
Δ app/views/hyrax/my/_work_action_menu.html.erb::might be a full contribute back to Hyrax
Δ app/views/hyrax/my/_search_header.html.erb::could contribute back catalog/sort_widget, create a blank partial for Hyrax
Δ app/views/hyrax/my/_collection_action_menu.html.erb::bring in <% if collection_presenter.collection_type_is_nestable? %> from Hyrax to ln 47 in Hyku, also review can?(:destroy, collection_presenter... if logic is the same then remove this partial
Δ app/views/hyrax/my/works/_list_works.html.erb::black_for contribute back required
Δ app/views/hyrax/my/collections/_list_collections.html.erb::black_for contribute back required, also slightly different translation above that would be nice to contribute back
Δ app/views/hyrax/collections/_media_display.html.erb::block_for contribute back
Δ app/views/hyrax/collections/show.html.erb::look at collection presenter treatment of banner_file (ln 9 in Hyku)
Δ app/views/hyrax/content_blocks/_form.html.erb::ok
Δ app/views/hyrax/base/_form_files.html.erb::bring over upload_file_limit information, update classes to bootstrap 4
Δ app/views/hyrax/base/_relationships.html.erb::ok
Δ app/views/hyrax/base/_show_actions.html.erb::requires a deep dive
Δ app/views/hyrax/base/_representative_media.html.erb::ok
Δ app/views/hyrax/base/show.html.erb::ok
Δ app/views/hyrax/base/_form_share.html.erb::bring in translations, like on ln 6, 15, 25, etc)
Δ app/views/hyrax/base/_form.html.erb::deleting, no longer needed
Δ app/views/hyrax/base/_attribute_rows.html.erb::deleting, no longer needed
Δ app/assets/javascripts/hyrax/thumbnail_select.es6::possibly a contribute back and remove, set up a UI test
Δ app/assets/javascripts/hyrax/app.js.erb::might contribute back as well
Δ app/assets/javascripts/hyrax/featured_works.js::ok
Δ app/services/hyrax/collection_thumbnail_path_service.rb::make into a decorator