Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Unable to add works to a collection through Bulkrax #195

Open
1 task
jillpe opened this issue Nov 27, 2023 · 2 comments
Open
1 task

🐛 Unable to add works to a collection through Bulkrax #195

jillpe opened this issue Nov 27, 2023 · 2 comments
Assignees
@ShanaLMoore @kirkkwang
Labels
bug Something isn't working Fall Sprint

Comments

@jillpe
Copy link

jillpe commented Nov 27, 2023 •
edited by ShanaLMoore
Loading

Story

A user should be able to attach works to collections using Bulkrax imports.

ref: https://assaydepot.slack.com/archives/C031E2NF43T/p1700837113222689

Acceptance Criteria

  • The user should be able to import a CSV that references a pre-existing Collection's ID in the parents column, to attach the work to the collection.

Testing Instructions

  • Download the following sample file. You may need to edit it.

  • Open it and confirm that the environment and tenant you're testing with has a Collection with this id. If not, update the parents column to an ID that exists in your system and save it.

  • Create a new CSV importer uploading the file from the previous step.

  • Verify the Collection has the works attached to it.
@jillpe jillpe added this to ATLA Hyku Nov 27, 2023
@jillpe jillpe converted this from a draft issue Nov 27, 2023
@ShanaLMoore ShanaLMoore moved this from Ready for Development to In Development in ATLA Hyku Nov 27, 2023
laritakr pushed a commit that referenced this issue Nov 27, 2023
🐛 Fix Bulkrax Collection Relationships job
5096eb7 
Importing a work with a collection did not add the work to the
collection. By moving the Hyrax::BasicMetadata include to the bottom,
relationship job now completes normally and makes the appropriate
relationships.

refs
- #195
laritakr pushed a commit that referenced this issue Nov 27, 2023
🐛 Fix Bulkrax Collection Relationships job
c289a93 
Importing a work with a collection did not add the work to the
collection. By moving the Hyrax::BasicMetadata include below the
property definition, the relationship job now completes normally and
makes the appropriate relationships.

refs
- #195
@laritakr laritakr mentioned this issue Nov 27, 2023
Merged
@ShanaLMoore ShanaLMoore changed the title Unable to add works to a collection through Bulkrax 🐛 Unable to add works to a collection through Bulkrax Nov 27, 2023
@ShanaLMoore ShanaLMoore added the bug Something isn't working label Nov 27, 2023
laritakr pushed a commit that referenced this issue Nov 27, 2023
🐛 Fix Bulkrax Collection Relationships job
38a7265 
Importing a work with a collection did not add the work to the
collection. By moving the Hyrax::BasicMetadata include below the
property definition, the relationship job now completes normally and
makes the appropriate relationships.

refs
- #195
laritakr pushed a commit that referenced this issue Nov 27, 2023
🐛 Fix Bulkrax Collection Relationships job
294437d 
Importing a work with a collection did not add the work to the
collection. By moving the Hyrax::BasicMetadata include below the
property definition, the relationship job now completes normally and
makes the appropriate relationships.

refs
- #195
laritakr pushed a commit that referenced this issue Nov 27, 2023
🐛 Fix Bulkrax Collection Relationships job
51b62bc 
Importing a work with a collection did not add the work to the
collection. By moving the Hyrax::BasicMetadata include below the
property definition, the relationship job now completes normally and
makes the appropriate relationships.

refs
- #195
@ShanaLMoore ShanaLMoore moved this from In Development to Softserv QA in ATLA Hyku Nov 28, 2023
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Nov 28, 2023 •
edited
Loading

QA RESULTS: Pass ✅

Tested on: Staging
Tested with: Sample File - Newsletter Imports - CSV for Importers - Atla IR - GenericWork.csv

  • The user should be able to import a CSV that references a pre-existing Collection's ID in the parents column, to attach the work to the collection.

Process

I created a Collection specifically for this test. The item count is 0. ID: df1e70f0-2eec-4ef3-a5d4-94e39a00ed29

I updated the sample file spreadsheet for the works to reference this Collection's ID, df1e70f0-2eec-4ef3-a5d4-94e39a00ed29, in the parents column.

Image

I created a new Bulkrax CSV Importer and uploaded this file.

Image

After all the background jobs were finished, I checked the Collection and could see the 4 works attached as expected.

Image

@ShanaLMoore ShanaLMoore moved this from Softserv QA to Client QA in ATLA Hyku Nov 28, 2023
@ckarpinski
Copy link
Contributor

This is working now

@ckarpinski ckarpinski moved this from Client QA to Deploy to Production in ATLA Hyku Nov 28, 2023
@ShanaLMoore ShanaLMoore moved this from Deploy to Production to Client Verification in ATLA Hyku Nov 29, 2023
@ckarpinski ckarpinski moved this from Client Verification to Done in ATLA Hyku Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShanaLMoore ShanaLMoore

@kirkkwang kirkkwang

Labels
bug Something isn't working Fall Sprint
Projects
ATLA Hyku
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ShanaLMoore @ckarpinski @kirkkwang @jillpe