-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't migrate or save records with Based Near #851
Comments
Do we need to add this for the resources?
|
Per LaRita, this is also a problem for Pals knapsack. |
TODO: based_near not working for collection, generic work, and image work types in adventist knapsack. However it works in Hyrax and Hyku. |
# Story Refs #851 # Expected Behavior Before Changes Using based near crashes the app. # Expected Behavior After Changes Based Near attributes save, display, and edit appropriately # Screenshots / Video <details> <summary></summary> </details> # Notes
I tested by adding location to newly created and old works in the ADL and SDAPI staging tenants. Everything works as expected. The locations show up and the works are functional. Saved changes are accurate. I believe all migration is complete, so my testing probably doesn't cover the lazy migration pathway, and that is probably irrelevant now anyway. |
Summary
We tried to lazy migrate this record with an edit/save.
When opening the record, London was the based near value. We tried to save it and got an error.
After returning back to the edit page, the values looked strange and were were never able to successfully save or migrate this record.
Maybe related? Another location error was spotted when we tried editing this record
I was able to edit this record by adding a location, but received an error on save.
When I went back to the edit page for this record, I received the same rdf_subject error.
Going back to the show page gives me a record not found error.
Creating a new work with a location field also fails.
Creating new works in demo.hyku-demo saved just fine so this issue may be specific to Adventist.
Acceptance Criteria
Testing Instructions
Create a work with a location and save.
Edit that work and save.
Find an old work with a location, edit and save.
Notes
related? https://github.com/samvera/hyrax/pull/6790/files
The text was updated successfully, but these errors were encountered: