Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't migrate or save records with Based Near #851

Open
3 tasks
ShanaLMoore opened this issue Oct 7, 2024 · 4 comments
Open
3 tasks

Can't migrate or save records with Based Near #851

ShanaLMoore opened this issue Oct 7, 2024 · 4 comments
Assignees
Labels
bug something isn't working high priority M1 Milestone 1 M2 Milestone 2

Comments

@ShanaLMoore
Copy link

ShanaLMoore commented Oct 7, 2024

Summary

We tried to lazy migrate this record with an edit/save.

When opening the record, London was the based near value. We tried to save it and got an error.

After returning back to the edit page, the values looked strange and were were never able to successfully save or migrate this record.

Image

Image

Maybe related? Another location error was spotted when we tried editing this record

Image

I was able to edit this record by adding a location, but received an error on save.

When I went back to the edit page for this record, I received the same rdf_subject error.

Going back to the show page gives me a record not found error.

Image

Creating a new work with a location field also fails.

Creating new works in demo.hyku-demo saved just fine so this issue may be specific to Adventist.

Acceptance Criteria

  • Devs should be able to convert records to valkyrie, with based_near properties set

Image

Testing Instructions

Create a work with a location and save.
Edit that work and save.
Find an old work with a location, edit and save.

  • all cases should successfully save without an error
  • all cases should persist the chosen location value

Notes

related? https://github.com/samvera/hyrax/pull/6790/files

@ShanaLMoore ShanaLMoore added bug something isn't working M2 Milestone 2 M1 Milestone 1 labels Oct 7, 2024
@ShanaLMoore ShanaLMoore changed the title Can't migrate records with Based Near Can't migrate or save records with Based Near Oct 7, 2024
@ShanaLMoore
Copy link
Author

ShanaLMoore commented Oct 8, 2024

Do we need to add this for the resources?

  # Fetch remote labels for based_near. You can remove this if you don't want
  # this behavior
  include Hyrax::IndexesLinkedMetadata

@ShanaLMoore
Copy link
Author

Per LaRita, this is also a problem for Pals knapsack.

@ShanaLMoore
Copy link
Author

TODO:

based_near not working for collection, generic work, and image work types in adventist knapsack. However it works in Hyrax and Hyku.

@ShanaLMoore ShanaLMoore assigned orangewolf and unassigned laritakr Oct 22, 2024
laritakr added a commit that referenced this issue Oct 25, 2024
# Story

Refs #851

# Expected Behavior Before Changes

Using based near crashes the app.

# Expected Behavior After Changes

Based Near attributes save, display, and edit appropriately

# Screenshots / Video

<details>
<summary></summary>

</details>

# Notes
@orangewolf orangewolf moved this from In Development to Deploy to Staging in Adventist Knapsack Oct 25, 2024
@laritakr laritakr moved this from Deploy to Staging to Client QA in Adventist Knapsack Oct 31, 2024
@KatharineV
Copy link
Collaborator

I tested by adding location to newly created and old works in the ADL and SDAPI staging tenants. Everything works as expected. The locations show up and the works are functional. Saved changes are accurate.

I believe all migration is complete, so my testing probably doesn't cover the lazy migration pathway, and that is probably irrelevant now anyway.

@KatharineV KatharineV moved this from Client QA to Deploy to Production in Adventist Knapsack Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working high priority M1 Milestone 1 M2 Milestone 2
Projects
Status: Deploy to Production
Development

No branches or pull requests

4 participants