Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Up: Verify if hyrax view overrides are necessary #798

Closed
2 tasks
ShanaLMoore opened this issue Sep 11, 2024 · 0 comments
Closed
2 tasks

Clean Up: Verify if hyrax view overrides are necessary #798

ShanaLMoore opened this issue Sep 11, 2024 · 0 comments
Assignees
@laritakr
Labels
M3 Milestone 3

Comments

@ShanaLMoore
Copy link

ShanaLMoore commented Sep 11, 2024 •
edited
Loading

Summary

We've discovered that some partial overrides are problematic and no longer necessary.

ref:

This task is to go through the remaining hyrax views directory to determine if the overridden partials are still needed.

This process can help to prevent other broken partials.

Acceptance Criteria

  • Only the necessary overrides remain

Screenshots or Video

Testing Instructions

To be filled out by dev

Notes
@ShanaLMoore ShanaLMoore added the M3 Milestone 3 label Sep 11, 2024
@laritakr laritakr mentioned this issue Sep 11, 2024
Merged
laritakr added a commit that referenced this issue Sep 13, 2024
@laritakr
Sync views with Hyrax/Hyku (#801)
1dee930 
# Story

To make future upgrades easier, this work attempts to remove unnecessary
views, and document the purpose of the overrides for views which are
needed.

Refs #798

# Expected Behavior Before Changes

# Expected Behavior After Changes

No behavior changes are expected.

# Screenshots / Video

<details>
<summary></summary>

</details>

# Notes
@jillpe jillpe closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laritakr laritakr

Labels
M3 Milestone 3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ShanaLMoore @laritakr @jillpe