Valkyrie: Blank metadata properties should not display on the show page

[KatharineV]

Summary

I imported 3 books from OAI set adl:book, and when I opened the edit page on one and resaved it, the work page now shows a bunch of blank metadata fields that I didn't modify. These fields were and remain blank. Yet after edit/save, they now display on the public facing work page.

https://adl.s2.adventistdigitallibrary.org/concern/published_works/20121738_the_vatican_and_the_war_a_retrospect_and_forecast_being_a_review?locale=en

The fields are:

• Date issued
• Publication date
• Publication status
• Issue
• Date submitted
• Date accepted
• Date available

The author field displays on work pages even when it is blank in the metadata. See and compare example work: On Staging https://adl.s2.adventistdigitallibrary.org/concern/published_works/20000076_mizpah?locale=en and On Production https://adl.b2.adventistdigitallibrary.org/concern/published_works/20000076_mizpah (note this was an existing work, not a new work)

Acceptance Criteria

• If fields are blank they do not display
  • work show page
  • collection show page

Testing Instructions

Testing note: the staging site was partially reindexed resulting in most existing records being updated but not all. Our assumption is that the cut over will handle the update of all works in production. Creating new works (or collections) should pass QA.

PLEASE NOTE, if you still see blank fields the work needs to be reindexed. Until we perform a full reindex on the entire system, you can trigger it manually. Edit and save the work or collection without making changes.

• Create a work with only the required metadata. Visit its show page. Blank metadata properties should not be displayed.
• Create a collection with only the required metadata. Visit its show page. Blank metadata properties should not be displayed.

Notes

• If a record does not have a author (creator) the field will have ["0~"] due to an older version of the order_already gem.
• The newest version of the gem handles this issue. The gem version was updated in Hyku and in the submodule of this application.
• However, existing records in ADL with ["0~"] will not register the author (creator) field as blank and therefore do not display or sort properly.
• To fix this problem, all records with ["0~"] in the creator field need to be updated. This can be done with the following script:

concerns = Hyrax.config.curation_concerns.map{ |c| "#{c}Resource".safe_constantize } << CollectionResource

concerns.each do |concern|
  works = Hyrax.query_service.find_all_of_model(model: concern)
  works.each do |work|
    next unless work['creator'] == ["0~"]
    work.creator = []
    work.save
  end
end

[KatharineV]

Today I created one of every work type through the UI. I uploaded PDFs to every type. One one work, I uploaded a folder (compound work). I only entered the required metadata of title and rights. Here is what I'm seeing that I don't expect:

• The Author field shows on every work, despite being blank on the back end. It is not a required field and it should not display when empty.
• Thesis work type shows blank Author and Date Issued fields. https://adl.s2.adventistdigitallibrary.org/concern/theses/31fc88bf-6d79-4713-a04f-fca0c60881f5
• Published work is showing blank fields listed at the top of this ticket as well as blank Author field. https://adl.s2.adventistdigitallibrary.org/concern/published_works/375785d3-67b0-4997-b22f-31197a6eb35e
• Journal article is showing same blank fields as Published work. https://adl.s2.adventistdigitallibrary.org/concern/journal_articles/74dc700e-7875-4ae9-8eb0-4bdfb9b86d7f
• Exam Paper is showing blank Author and Date Available fields. https://adl.s2.adventistdigitallibrary.org/concern/exam_papers/ca9d6ce4-f9d9-4701-a8b3-704cf754eb14
• Dataset is showing blank Author, Date Issued, Publication Date, Date Collected, Date Submitted, Date Accepted, and Date Available fields. https://adl.s2.adventistdigitallibrary.org/concern/datasets/975e599a-c9f5-40fc-aa7f-ffdc6f19ad1a
• Conference item is showing blank Author, Date of event, Publication Date, Publication Status, Date Submitted, Date Accepted, and Date Available fields. https://adl.s2.adventistdigitallibrary.org/concern/conference_items/4c304332-fef3-4393-a54c-957411b1e5a0
• Image shows blank author field. https://adl.s2.adventistdigitallibrary.org/concern/images/5c3ff539-a835-430b-9d93-76175f72ec85
• Generic work shows blank Author field. https://adl.s2.adventistdigitallibrary.org/concern/generic_works/66f50a62-ca71-4c16-9a5a-1ec8d01a23de
• The compound work is not showing the blank UV, so I'm slightly concerned about how it will behave when the UV is fixed. The attached PDFs split and the parent/child works are listed in the item list. However, there is no indication that the UV would be showing the works if it was functioning on Staging. https://adl.s2.adventistdigitallibrary.org/concern/generic_works/a6adc2cd-cb6f-4b86-bdb7-4e3d766eba50

[sjproctor]

We created a solution for this problem but there is more to be done in the future: #807

[ShanaLMoore]

QA RESULTS: ❌ NEEDS REWORK

tested on STAGING

I created a conference item and filled in only the required fields.

• Blank metadata is not displaying on the work's show page. ✅

I created a collection and filled in only the required fields.

• blank metadata is not displaying on the collection's show page ❌

[ShanaLMoore]

QA Results: ✅ PASS

PLEASE NOTE, if you still see blank fields on pre-existing works, it needs to be reindexed. Until we perform a full reindex on the entire system, you can trigger it manually. Edit and save the work or collection without making changes.

WORK ✅ PASS

Test on STAGING

I filled in only the required fields (title and rights statement):

• Create a work with only the required metadata. Visit its show page. Blank metadata properties should not be displayed.

COLLECTION ✅ PASS

Tested on STAGING

I filled in only the required field (title):

public view

• Create a collection with only the required metadata. Visit its show page. Blank metadata properties should not be displayed.

[sjproctor]

concerns = Hyrax.config.curation_concerns.map{ |c| "#{c}Resource".safe_constantize } << CollectionResource

concerns.each do |concern|
  works = Hyrax.query_service.find_all_of_model(model: concern)
  works.each do |work|
    next unless work.singleton_class.name.nil?
    next unless work.creator.last.blank?
    next if work.id == 'c7019db2-067c-403c-95b0-11c06715d5ca'
    array = work.creator
    array.pop
    work.creator = array
    work.save
  end
end

[KatharineV]

Tested a new work on staging, and only added metadata to three fields. No blank fields are showing. https://adl.s2.adventistdigitallibrary.org/concern/generic_works/600641e8-8cc7-453c-a12d-c0ad34a027cf

Tested a new collection as well, and it also works as expected. Two fields have metadata, and two fields show. https://adl.s2.adventistdigitallibrary.org/collections/ed64bf09-7142-4251-9abe-698cc6568a10?locale=en