Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Optionally remove the Status handler_id prefix #320

Closed
5 tasks done
kopf-archiver bot opened this issue Aug 18, 2020 · 4 comments
Closed
5 tasks done

[PR] Optionally remove the Status handler_id prefix #320

kopf-archiver bot opened this issue Aug 18, 2020 · 4 comments
Assignees
Labels

Comments

@kopf-archiver
Copy link

kopf-archiver bot commented Aug 18, 2020

A pull request by lack at 2020-03-02 21:48:59+00:00
Original URL: zalando-incubator/kopf#320
 

What do these changes do?

As proposed in issue #319, this introduces an optional status_prefix boolean that can be added to any resource handler definition. If set to True (or omitted), status returned by the handler is still placed beneath the handler_id in the resulting object's status subresource. If set to False, the status returned by the handler is use at the top-level of the status subresource.

Description

Fully implements the proposal in issue #319.

Issues/PRs

Issues: #319

Type of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt

Commented by ps-jay at 2020-08-20 05:16:45+00:00
 

This would be a really nice feature to have


Commented by philipp-sontag-by at 2020-08-22 11:27:17+00:00
 

Hey lack,
is there any chance you would be willing to update this branch and move the PR to the new repository at https://github.com/nolar/kopf?

If you don't have time at the moment would it be ok if I pick this up based on the changes you already made?


Commented by lack at 2020-08-22 19:10:46+00:00
 

philipp-sontag-by : I'll try to redo this in the other repo, but I may not have time in the near future (starting a new job this week). I'd also be happy for you to carry this forward if you have time. Let me know here if you've got it in another PR so we don't duplicate effort.

@kopf-archiver kopf-archiver bot closed this as completed Aug 18, 2020
@kopf-archiver kopf-archiver bot changed the title [archival placeholder] [PR] Optionally remove the Status handler_id prefix Aug 19, 2020
@kopf-archiver kopf-archiver bot reopened this Aug 19, 2020
@ps-jay
Copy link

ps-jay commented Aug 20, 2020

I'm keen for this PR to be considered

@psontag
Copy link
Contributor

psontag commented Aug 22, 2020

@nolar would you accept a contribution for this issue?

@nolar nolar self-assigned this Aug 22, 2020
@samgiles
Copy link

I've ported the original PR in #579!

@nolar
Copy link
Owner

nolar commented Sep 3, 2021

Closed together with #579 — see the reasoning in #579 (comment)

@nolar nolar closed this as completed Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants