Skip to content
This repository has been archived by the owner on Feb 28, 2020. It is now read-only.

Add Comment field to donors #9

Closed
wants to merge 1 commit into from
Closed

Add Comment field to donors #9

wants to merge 1 commit into from

Conversation

morenoh149
Copy link
Contributor

  • add comment string to Donor model
  • add comment textarea element to charge form
  • change leaderboard from ordered list to table. Gives us
    equidistant spacing for free.

closes #4

@morenoh149
Copy link
Contributor Author

Wasn't able to test it properly but I think it's right. Should make a db/seeds.rb file.

@morenoh149
Copy link
Contributor Author

force pushed an amend. That's why the diff looks funky.

@patrickod
Copy link
Member

This also needs a migration for the comment column on donor?
On Sun, Feb 22, 2015 at 04:45:12AM -0800, Harry Moreno wrote:

  • add comment string to Donor model

  • add comment textarea element to charge form

  • change leaderboard from ordered list to table. Gives us
    equidistant spacing for free.
    You can view, comment on, or merge this pull request online at:

    Add Comment field to donors #9

-- Commit Summary --

  • Add Comment field to donors

-- File Changes --

M app/models/donor.rb (1)
M app/views/donations/_charge_form.html.erb (7)
M app/views/donations/_leaderboard.html.erb (13)

-- Patch Links --

https://github.com/patrickod/noisebridge-donate/pull/9.patch
https://github.com/patrickod/noisebridge-donate/pull/9.diff

Reply to this email directly or view it on GitHub:
#9

@morenoh149
Add Comment field to donors
17bf926 
* add comment string to Donor model
* validate comment is no longer than 200 characters
* add comment textarea element to charge form
* make comment textarea non-resizable via css
* change leaderboard from ordered list to table. Gives us
equidistant spacing for free.
* add comment column to database via migration
@morenoh149
Copy link
Contributor Author

added the migration file @patrickod

@patrickod
Copy link
Member

Going to leave this out for the moment.

@patrickod patrickod closed this Jun 13, 2015
@morenoh149 morenoh149 deleted the hm-add-description-to-Donor branch June 14, 2015 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: optional URL field displays next to donors name
2 participants
@morenoh149 @patrickod