Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there breaking changes in 4.0+? #162

Closed
tswaters opened this issue Oct 1, 2022 · 2 comments
Closed

Are there breaking changes in 4.0+? #162

tswaters opened this issue Oct 1, 2022 · 2 comments
Labels
question ❓ Information is being requested

Comments

@tswaters
Copy link

tswaters commented Oct 1, 2022

Just coming from node-oauth2-server#740 and I see there was a major version bump from 3 -> 4, but the chnagelog doesn't show any breaking changes. Was there anything to warrant a major bump? I'm wanting to switch to this package in a project I have and am unsure if I need to worry about breaking changes.

@jankapunkt
Copy link
Member

Hi @tswaters thank your for interest in this package. We did the major bump mainly to have a clean break from the original project. Besides that you should be able to upgrade without no major breaks.

However there are minor things that may be "breaking", depending on how you view it. Especially you should check on changed and fixed in the changelog.

All of these changes/fixes were considered as required in order to comply with the standard or fix issues.
However, if you find issues after the upgrade that are considered as "major" breaks then please let us know.

@jankapunkt jankapunkt added the question ❓ Information is being requested label Oct 1, 2022
@tswaters
Copy link
Author

tswaters commented Oct 2, 2022

Thanks for the quick response, this answers my question.

@tswaters tswaters closed this as completed Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question ❓ Information is being requested
Projects
None yet
Development

No branches or pull requests

2 participants