Health check returns HTTP status 200 even when unhealthy (#371)

* fix: return 500 if health check result is unhealthy

* fix: allow status 500 for a successful health check result in sdk

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

packages/sdk/src/endpoints/Endpoint.ts

@@ -5,8 +5,8 @@ import { ConnectorHttpResponse } from "../types/ConnectorHttpResponse";
 export abstract class Endpoint {
     public constructor(private readonly httpClient: AxiosInstance) {}
 
-    protected async getPlain<T>(path: string): Promise<T> {
-        const reponse = await this.httpClient.get<T>(path, { validateStatus: (status) => status === 200 });
+    protected async getPlain<T>(path: string, validateStatus?: (status: number) => boolean): Promise<T> {
+        const reponse = await this.httpClient.get<T>(path, { validateStatus: validateStatus ?? ((status) => status === 200) });
         return reponse.data;
     }
 

packages/sdk/src/endpoints/MonitoringEndpoint.ts

@@ -3,7 +3,7 @@ import { Endpoint } from "./Endpoint";
 
 export class MonitoringEndpoint extends Endpoint {
     public async getHealth(): Promise<ConnectorHealth> {
-        return await this.getPlain("/health");
+        return await this.getPlain("/health", (status) => status === 200 || status === 500);
     }
 
     public async getVersion(): Promise<ConnectorVersionInfo> {

src/infrastructure/httpServer/HttpServer.ts

@@ -222,7 +222,8 @@ export class HttpServer extends ConnectorInfrastructure<HttpServerConfiguration>
     private useHealthEndpoint() {
         this.app.get("/health", async (_req: any, res: any) => {
             const health = await this.runtime.getHealth();
-            res.status(200).json(health);
+            const httpStatus = health.isHealthy ? 200 : 500;
+            res.status(httpStatus).json(health);
         });
     }