Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to dataclasses (PEP 557) #176

Open
mrbermell opened this issue Oct 10, 2021 · 2 comments
Open

Convert to dataclasses (PEP 557) #176

mrbermell opened this issue Oct 10, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mrbermell
Copy link
Collaborator

Makes the code readable and maintainable. Mainly applicable to core/model.py. Good to have done before starting with 2020 rules.
@mrbermell mrbermell added enhancement New feature or request good first issue Good for newcomers labels Oct 10, 2021
@njustesen
Copy link
Owner

This would be a great improvement but I don't think it works for <3.7. Maybe it's still worth it.

@mrbermell
Copy link
Collaborator Author

True. I don't know how to reason about this. Maybe the lifespan of python releases is a good indication? In that case Python 3.6 will not receive updates after this year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@njustesen @mrbermell