Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize unused imports #11

Open
nivekcode opened this issue Jun 29, 2020 · 4 comments
Open

Optimize unused imports #11

nivekcode opened this issue Jun 29, 2020 · 4 comments
Labels

Comments

@nivekcode
Copy link
Owner

No description provided.

@nivekcode nivekcode added the enhancement New feature or request label Jul 5, 2020
@shaharkazaz
Copy link
Collaborator

shaharkazaz commented Aug 21, 2020

@kreuzerk I think that this is already covered by the lint rules. are you sure we want to implement it here as well? 🤔

@nivekcode
Copy link
Owner Author

I added the issue based on the discussion here: https://twitter.com/ribizlim/status/1277545201255550977

@nivekcode
Copy link
Owner Author

But actually you are right. This is already covered by the lint rules. But if its easy to achieve it would be a nice feature.

I imagine a developer who adds an unused import and then commits its changes. The build then fails because of the unused imports. He then would need to fix it and commit again. If import-conductor would offer this feature this would not happen. Since the unused import would be removed during the commit hook.

I see it more as a nice to have feature instead of something that is necessary. What do you think?

@shaharkazaz
Copy link
Collaborator

I agree that it's not a necessity for 2 main reasons:

  • The main IDEs have built-in support for cleaning unused imports.
  • My setup (which I think it's common) includes a pre-commit hook for the lining so I won't be able to commit these cases.

I do agree that it's a nice to have feature and even make our lives easier, I'll add the PRs welcome tag, maybe someone from the community would pitch in 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants