-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize unused imports #11
Comments
@kreuzerk I think that this is already covered by the lint rules. are you sure we want to implement it here as well? 🤔 |
I added the issue based on the discussion here: https://twitter.com/ribizlim/status/1277545201255550977 |
But actually you are right. This is already covered by the lint rules. But if its easy to achieve it would be a nice feature. I imagine a developer who adds an unused import and then commits its changes. The build then fails because of the unused imports. He then would need to fix it and commit again. If import-conductor would offer this feature this would not happen. Since the unused import would be removed during the commit hook. I see it more as a nice to have feature instead of something that is necessary. What do you think? |
I agree that it's not a necessity for 2 main reasons:
I do agree that it's a nice to have feature and even make our lives easier, I'll add the |
No description provided.
The text was updated successfully, but these errors were encountered: