-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Environments (container or conda env) #14
Comments
This is great thank you! |
@oesteban any reason you are not using neurodocker for it? We are trying to consolidate building various versions of those tools into one place. Those seem handcrafted for a specific use case. Also eventually these pydra repos will use testkraken to test against different versions. So the containers would have to be created for several versions. |
We're entertaining the idea of multi stage docker builds, that's the only reason for it. It's true these hardly allow versioning at the moment |
MNT: Move back to declarative package finding
I would suggest we switch to installing FSL with conda, e.g.,
|
is john still maintaining |
No. John's AFNI channel is stuck in 2020. I still use it (hence why it slipped into that command I meant just to demo FSL...), but I wouldn't consider it an official channel. The FSL installer now creates a conda environment, which is how I found this. So I'd consider using it as a conda channel stable but possibly not recommended to general users (as opposed to going through their installer). @pauldmccarthy or @hanayik could probably clarify, though. |
I noticed it too during deployment this week. I reckoned there was a talk at OHBM BrainHack this year about Conda's FSL packages coming soon. I wonder how far away we are from conda installing individual FSL binaries. That would be such an improvement. |
Yes, that was @hanayik. It was extremely pleasing to hear.
I'm doing it to run tests. I plan to use it in nipreps testing environments, now that neurodebian has stopped packaging FSL. Assuming I'm not outvoted, I'm excited to see how much it slims down fMRIPrep Docker images in 23.0. |
Hi @effigies, @satra, @ghisvail, etc; yes - we have migrated FSL to being fully conda-based, so advanced users (i.e. you) should be able to use conda/mamba directly to install specific FSL components if you wish. I've been compiling some documentation describing the new system which you might find handy. We are sourcing packages from our public channel, and from One thing to note is that with a command like:
you will be getting the latest available version of the
Another potential issue which you may encounter while we are transitioning to this new system - while the dependencies for all C/C++ projects should be accurate (as they wouldn't be buildable otherwise), there may be some under-/over-specifications in the dependencies for bash/tcl/python scripts. We're planning to fix these on a case-by-case basis, so please report any issues you encounter! |
Are the base dependencies pinned so that installing the 6.0.6.1 version of fugue will install the 6.0.6.1 version of all its dependencies, or would we need to pin all of them? |
@effigies yes, this should be the case, at least for the binary projects (we've been a bit more lenient w.r.t. pinning for the other projects). |
It will be useful to have a container with FSL for CI. For example, the test for Complex interface is failing, but it is running fine locally for me and Dorta. This should be a good issue to start with for more consistency.
The text was updated successfully, but these errors were encountered: