Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests to solidify assumptions #143

Open
2 tasks
yarikoptic opened this issue Feb 1, 2018 · 1 comment
Open
2 tasks

Add more tests to solidify assumptions #143

yarikoptic opened this issue Feb 1, 2018 · 1 comment

Comments

@yarikoptic
Copy link
Member

Fixes in #129 pointed out to a number of assumptions we nohow test for:

  • session/subject from dicoms are passed into conversion
  • session or subject specified in the cmdline will be used to override session/subject from dicoms
@yarikoptic yarikoptic mentioned this issue Feb 1, 2018
Merged
4 tasks
@yarikoptic
Copy link
Member Author

I thought I did introduce some tests for those, but I failed to locate them, so I guess it would be an outstanding issue as of 0.5 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yarikoptic