Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready for review #26

Closed
jagruti8 opened this issue Oct 24, 2022 · 5 comments
Closed

Ready for review #26

jagruti8 opened this issue Oct 24, 2022 · 5 comments

Comments

@jagruti8
Copy link
Collaborator

Hi, @pxr687 @eilidhmacnicol @matthew-brett @effigies @oesteban - please can you review our project?

@jagruti8
Copy link
Collaborator Author

Hi, @pxr687 @eilidhmacnicol @matthew-brett @effigies @oesteban - I made some more changes to the code. If it is not yet reviewed its fine, else it would be great if the updated one can be reviewed again. Thanks

@oesteban
Copy link
Contributor

Hi @jagruti8,

I can see 7 open issues by @Nauman702 and @mtach -- what is the expectation for those? The team should gather up and decide whether they can just be closed or merged in.

We will review the main branch as soon as the team can confirm that is what needs to be reviewed.

@jagruti8
Copy link
Collaborator Author

Hi @oesteban , yeah now the main branch can be reviewed. Thanks

@oesteban
Copy link
Contributor

I'll be reviewing this project over the following days. Whenever I find something that could be addressed, I'll post new issues (e.g., #28)

@oesteban
Copy link
Contributor

Note: I'll notify you when I'm done (and will also nudge the other course instructors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants