Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Parameters do not handle NoneType #138

Open
shadetree01010100 opened this issue Aug 17, 2018 · 0 comments
Open

Command Parameters do not handle NoneType #138

shadetree01010100 opened this issue Aug 17, 2018 · 0 comments

Comments

@shadetree01010100
Copy link
Contributor

If a command parameter is omitted from an API request to a command, the command method will be called with omitted param(s) passed a string "None", instead of an actual NoneType.

nio-blocks/buffer#12

It looks like none of the command paramaters support this, in the buffer block use case the group param is typically a string, but can be None.

Should StringParameter handle the special case of None where allow_none = True? Is there another Parameter type that might be a better fit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant