Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a separate browser module #17

Open
danimoh opened this issue Nov 7, 2020 · 0 comments
Open

Provide a separate browser module #17

danimoh opened this issue Nov 7, 2020 · 0 comments

Comments

@danimoh
Copy link
Member

danimoh commented Nov 7, 2020

The lib uses Node builtins like module, global, require, Buffer which get polyfilled by bundlers like webpack and result in bundling big polyfills like buffer which are completely unnecessary in the browser.
Also the polyfill dom-parser is getting bundled, which is also unnecessary in the browser.
Therefore a separate browser specific module should be provided which doesn't include any of these aforementioned node specific features.

onmax added a commit that referenced this issue Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant