Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not really an issue but: #5

Open
IamGiel opened this issue Mar 6, 2020 · 2 comments
Open

Not really an issue but: #5

IamGiel opened this issue Mar 6, 2020 · 2 comments

Comments

@IamGiel
Copy link

IamGiel commented Mar 6, 2020

I added button so that we can navigate to dashboard by clicking the Title in the navbar.
I upgraded the angular cli to current version (9).
Angular.json has been created, replacing angular-cli.json.

Hope I can create a pull request. I was trying but I could not.

Here is my cloned version of your repo: [https://github.com/IamGiel/forking-dynamic-reusable-responsive-components]

Thanks,
Gel

@nima200
Copy link
Owner

nima200 commented Mar 7, 2020

Hey Gel (Giel? Pardon me if I'm typing your name wrong, basing it on your footnote),
It seems like GitHub repository you've linked which I took a look at in your profile is not an official fork of this repository.
You do however have another repository which is, but it seems like your changes are not on top of that one.
To create a pull-request, you need to do it on the one that indeed is a fork.
Please see the following images:
image
image
As you can see in the first image, the repository IAmGiel/angular-dashboard is marked as a fork by GitHub and will be able to be placed in a pull request while IamGiel/forking-dynamic-reusable-responsive-components is not.

Looking forward to reviewing your PR once you've managed to cherry-pick your changes to IAmGiel/angular-dashboard!

Thank you for your contribution,
Nima

@IamGiel
Copy link
Author

IamGiel commented Mar 7, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants