libmount: exec mount helpers with posixly correct argument order #3309
+31
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilfsuser5678
changed the title
This improves compatibility with non-gnu userspaces. On systems where the libc provides posix getopt instead of gnu getopt, mount helpers which use getopt to parse arguments will not parse options which appear after non-option arguments. This patch ensures mount/unmount work as expected in this situation. mount: fix expected argument order for mount helpers in tests
nilfsuser5678
force-pushed
the
posix-argument-order
branch
from
712ff56 to
2d680b7
Compare
|
The failed rpm-build:fedora-rawhide-i386 is irrelevant (related to the lsns/filter magic). |
t-8ch
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libmount: exec mount helpers with posixly correct argument order
This improves compatibility with non-gnu userspaces.
On distributions such as Chimera Linux and Void Linux Musl where the libc provides posix getopt instead of gnu getopt, mount helpers which use getopt to parse arguments will not parse options which appear after non-option arguments. In particular, mount.nilfs2 from nilfs-utils is affected by this and on such systems, mounting NILFS filesystems fails in some situations when the mount utility is from util-linux and the nilfs mount helper is present. This patch ensures mount/unmount work as expected on such systems with no negative effects or compromises for ordinary GNU/linux.
Fixes nilfs-dev/nilfs-utils#12 and chimera-linux/cports#3214