Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class feedback-highlighted won't go away when the feedback is closed #26

Open
gauravmishr opened this issue Jul 25, 2013 · 4 comments
Open

Comments

@gauravmishr
Copy link

I am facing this in the Firefox 23.0, fine in FF22.0 & for chrome 28.0.1500.72 m it is also fine.

The concern is with canvas tag highlighted area, which won't go/fade away. while clicking on close button of the send feedback.
untitled
which is leaving box-shadow patches on the screen..

and i noticed there is one white space, ahead of the class feedback-highlighted.

@Kwopr
Copy link

Kwopr commented Nov 22, 2013

Hi,
Here is the why:

http://whereswalden.com/2013/08/05/new-in-firefox-23-the-length-property-of-an-array-can-be-made-non-writable-but-you-shouldnt-do-it/

And, here is a fix:

  • Go to Core.js, find the removeElements() function (line 10),
  • Replace this line:
    var item = Array.prototype.pop.call( remove );
    to:
    var item;
    if ( remove instanceof HTMLCollection )
    item = remove[0];
    else
    item = Array.prototype.pop.call( remove );

@simplenotezy
Copy link

Thank you Kwopr!

@gauravmishr
Copy link
Author

Thank you @Kwopr! working fine with the same.

@luksha
Copy link

luksha commented Oct 7, 2014

Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants