Feature Request: Enable inticating carb entries on the graph

[motinis]

In a similar way to how there are little markers for boluses, it would be great if, for example, a little white dot could be put on the graph to mark carb entries. This is useful when tracking from a far to know for example if a kid has received a low treatment yet or not without needing to check alternative applications.

Thank you!!

[dhermanns]

You mean like so:

[motinis]

Yep. That looks good

[dhermanns]

So it should already work this way. I think right now it's displayed only when carbs AND bolus has been applied.

But this is just from memory.

[motinis]

Ok - this is odd then. When you say carbs have been applied I'm assuming you're not talking within Nightguard, right? That it's pulling them from NS? I have 3.9.2.906 installed.

[dhermanns]

The app transfers the entered carbs to NS, yes. And retrieves them from the NS Backend.

[motinis]

So in I it case Loop is the one recording the carbs and they aren’t displayed for us.

[dhermanns]

You could compare the entries in nightguard that loop creates, versus the ones from NS/Nightguard. I would expect that there a differences.

[motinis]

Here is the format for Loop carb treatments:

{
    "_id": "6799e6bc69ef86c8bedc4f22",
    "carbs": 24,
    "eventType": "Carb Correction",
    "syncIdentifier": "A3D3269F-1684-4B76-9544-44F242C277AA",
    "absorptionTime": 180,
    "timestamp": "2025-01-29T08:20:22Z",
    "userEnteredAt": "2025-01-29T08:28:22Z",
    "enteredBy": "loop://iPhone",
    "foodType": "🌮",
    "created_at": "2025-01-29T08:20:22.000Z",
    "utcOffset": 0,
    "insulin": null
  }

Looking at the code in Nightguard I see:

{"eventType": "Carb Correction",
        "carbs": \(carbs),
        "duration": 0,
        "enteredBy": "nightguard"}

Note that in Loop carbs are double and not int (e.g. 3.5 is fine).

Perhaps the difference here then is in terms of "absorptionTime" vs "duration"?

[motinis]

The relevant code in Nightguard:

 fileprivate func extractCarbCorrection(_ jsonTreatment: [String : Any]) {
        
        if let id = jsonTreatment["_id"] as? String {
            if isNew(id: id) {
                if let date = jsonTreatment["mills"] as? Double {
                    let carbs = jsonTreatment["carbs"] as? Int ?? 0
                    
                    addTreatment(
                        treatment:
                            CarbCorrectionTreatment.init(id: id, timestamp: date, carbs: carbs))
                }
            }
        }
    }

So I think the problem is mainly in the "mills" field as opposed to the "timestamp" field.