Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SaveMode in SequenceSettings #32

Open
jdeschamps opened this issue Dec 7, 2018 · 1 comment
Open

SaveMode in SequenceSettings #32

jdeschamps opened this issue Dec 7, 2018 · 1 comment

Comments

@jdeschamps
Copy link

jdeschamps commented Dec 7, 2018

It seems to me that the only way to change the "SaveMode" (single or multi) settings of a DefaultDatastore is through the MDA dialog.

If one wants to run an acquisition with the AcquisitionManager from a plugin, it would be helpful to be able to store the SaveMode in the SequenceSettings. Then within the DefaultAcquisitionManager runAcquisition(...) methods, the DefaultDatastore save mode could be changed.

(if you feel this is a good idea, I can probably create a pull request)

EDIT: I overlooked the UserProfile in which it is stored. I guess one can set the value of this parameter through the current profile, but it is a parameter we often change so it would make sense given our use to have it more exposed (if it makes sense obviously).

@nicost
Copy link
Owner

nicost commented Feb 13, 2019

Sorry for the delay in commenting! I very much agree that this functionality is missing and is important. I do remember Mark having strong ideas about this, but forgot what those were. The implementation now looks very iffy: the buttons in the MDA dialog set the preferred save mode in the DefaultDatastore using a static method, which in turns sets the an entry in the user profile (I am not sure if the latter is just to remember the setting or that it is actually applied at the beginning of the acquisition).

So, it looks as if a first step could be to have a SequenceSettings method for this (which should be open to extending save methods, because we will add new methods in the future), and make sure that the desired method is set based on this SequenceSetting when running the acquisition.

Would be great if you could work on a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants